diff mbox series

swupdate-client: use CV for synchronization

Message ID 20201226111539.13881-1-sbabic@denx.de
State Accepted
Headers show
Series swupdate-client: use CV for synchronization | expand

Commit Message

Stefano Babic Dec. 26, 2020, 11:15 a.m. UTC 
Switch to condition variable to synchronize when an update is finished
because using mutex as semaphore raises issues with coverity tool.

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 tools/swupdate-client.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)
diff mbox series

Patch

diff --git a/tools/swupdate-client.c b/tools/swupdate-client.c
index 3e29bad..94f712b 100644
--- a/tools/swupdate-client.c
+++ b/tools/swupdate-client.c
@@ -56,7 +56,8 @@  bool run_postupdate = false;
 int end_status = EXIT_SUCCESS;
 char *software_set = NULL, *running_mode = NULL;
 
-pthread_mutex_t mymutex;
+static pthread_mutex_t mymutex;
+static pthread_cond_t cv_end = PTHREAD_COND_INITIALIZER;
 
 /*
  * this is the callback to get a new chunk of the
@@ -110,6 +111,8 @@  static int end(RECOVERY_STATUS status)
 			fprintf(stderr, "Running post-update failed!\n");
 	}
 
+	pthread_mutex_lock(&mymutex);
+	pthread_cond_signal(&cv_end);
 	pthread_mutex_unlock(&mymutex);
 
 	return 0;
@@ -125,10 +128,6 @@  static int send_file(const char* filename) {
 		return EXIT_FAILURE;
 	}
 
-	/* synchronize with a mutex */
-	pthread_mutex_lock(&mymutex);
-
-
 	/* May be set non-zero by end() function on failure */
 	end_status = EXIT_SUCCESS;
 
@@ -151,10 +150,9 @@  static int send_file(const char* filename) {
 		return EXIT_FAILURE;
 	}
 
-	/* Now block */
-	pthread_mutex_lock(&mymutex);
-
 	/* End called, unlock and exit */
+	pthread_mutex_lock(&mymutex);
+	pthread_cond_wait(&cv_end, &mymutex);
 	pthread_mutex_unlock(&mymutex);
 
 	if (filename)