From patchwork Wed Nov 11 12:03:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefano Babic X-Patchwork-Id: 1398193 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::33b; helo=mail-wm1-x33b.google.com; envelope-from=swupdate+bncbcxploxj6ikrbj5gv76qkgqetqkmdxq@googlegroups.com; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=X82U5Qzc; dkim-atps=neutral Received: from mail-wm1-x33b.google.com (mail-wm1-x33b.google.com [IPv6:2a00:1450:4864:20::33b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CWNgJ1d7tz9sSs for ; Wed, 11 Nov 2020 23:03:56 +1100 (AEDT) Received: by mail-wm1-x33b.google.com with SMTP id h2sf827429wmm.0 for ; Wed, 11 Nov 2020 04:03:55 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1605096232; cv=pass; d=google.com; s=arc-20160816; b=wNWiCFulCrdr+XYmZXNvq3Nt8pWc5yGe9qGJ87CYrKV33w7UurVQlMwOohFS130PEF cL5NlVV4bEL88mmh1TcHDBSQhYGUy3ugv2kNlOT6E7JXQtjqdpSMoE3FYpvAFmlPCKEO Gp9APyev6uXaV+NxLC934VV5ACfUi8ag8AcUpYnmQ+UqLD8CWL8RlzMVpkaal+zzkf+7 mSEC0yS4UEdvO9SxXJQinlp22L9RQWDlAyjUwAS3CmzZGf+93J3LB/ixF0Ad72SIKO08 Ens7JcSnoX1eF1+YRbmz6rleydYYSpZ1V+Q/sJDltf+OqF598VaDNifjWlEr599tGCjR gtvw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:dkim-signature; bh=7et86/V3jeNle7WHOytq+vYITWWvOEgGliZwISLURZw=; b=u1QJnBTpJ5XzbUhv2LcLwQlJEHkywWgoTXtJzF/XR6jy39uHwB+JzyGZjjwntBatTS rxuM6GN4Wtb5Zzw2Ilt8oN76Ukzi9Rl4InZjdzHUc5bitSpZ9Ws2A+/f8wr4yrQTK+ZI jpBqQhry8Gjy98z3sP7YHfN7uP/+wo5Hdo5oHC+i+PDtGptYVINCMn8Cbp84s6NtmSzu xrZ8T3vbPRrrS4vxliTqHzWVCyyE9uTh89QDWr7xkr/tRFwCNWZEZJadATVGUCfHbwS+ ob57tJ1SHV+JxrT4+ZefO1MV+kFm1OYbvD6EjtwuIvqX1lW0rNoq0BLTigmDpV2MfcRN 9tCg== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=7et86/V3jeNle7WHOytq+vYITWWvOEgGliZwISLURZw=; b=X82U5QzcIq9ImiO1lAsIKcwxFTteI8DLs5CuUde0tKyRSjF6D/V71QMdleswRP0g3r ox+Rw/8SDgRTTpayeIt1sd7f61/JxoZLZd8fUEJ8xcpEy5m+QLIEK+yIqHguG/ovUjrw GSddWC1KlTIHAWILsZwfqhzOMdAKQ0QFUroWX9MnIUok287Yjc5qxQeLTA4OsRHwkQeQ m3TlP8VcU1zLHYy7NFR32tYuIKfL1kmJoQdbc7IOylbmh/SUl7ZQwmVRYPTUxgjAr7F+ o6lI9dIov1UHiBs1fGo/ycVa2kZaZNV+uxQsJFJMH2X+TpiJjw5Kmioz9+PvXOak1NAF 9LgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-spam-checked-in-group:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=7et86/V3jeNle7WHOytq+vYITWWvOEgGliZwISLURZw=; b=JelSHccIhM8bMyD8zgBOBpuDr2AgxcgjXEgAQ97Q6whjt/aLGJo5FVzeDV2jgTeKJp Lt2gKaISGHFXTt4cfsBlWhHmpAEvXIfHQtHw9WuSxLUguAQxw33VhT+dEsXsQew9afwB H8MX/UKTo97TOyKt1jQBRvLAjz5QGDP8US6miuPNVmUJ7NK6LOmuatb/c7EaImc1oaaA sNbO5mA1QBTS/OH1JAvZ1Vk6oKZBJvjKWLFcE2QQgm8cYQSx4sdBo6W+HFyovhPuiV/1 fGOq+6G7UY4FBjq0xNcdqjdbIc9BFdNhScDpEQHBj76JeB16UxYR2BcM8pRzRyJjxMU4 QsLw== Sender: swupdate@googlegroups.com X-Gm-Message-State: AOAM533+DJTDnZids/8nZW2G0d9lAUYSJymgOwa6Ap6oiF0L8nk5RhJq CwSJ8DD2AaoK8mygEQX0kgU= X-Google-Smtp-Source: ABdhPJx1ODupIEXp8ISPLrlcchduxjaN9KLOn1Vt4W0d5uie4pKV3qV6fED1+yAoWQ6yzGRTzf6jmA== X-Received: by 2002:a1c:bc08:: with SMTP id m8mr3948369wmf.137.1605096232478; Wed, 11 Nov 2020 04:03:52 -0800 (PST) X-BeenThere: swupdate@googlegroups.com Received: by 2002:a7b:c354:: with SMTP id l20ls1134930wmj.0.canary-gmail; Wed, 11 Nov 2020 04:03:51 -0800 (PST) X-Received: by 2002:a1c:2643:: with SMTP id m64mr3849336wmm.28.1605096231236; Wed, 11 Nov 2020 04:03:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1605096231; cv=none; d=google.com; s=arc-20160816; b=XL1b1ZT7y6vhJrFXzvOnWRolA0vrzMpLzI1U4oRIzywX7vVINe6kuIyoztVqhmqTLQ h6IaYWrRZ1UnsoeIariZhPuS5+jos26j+KT54ENZW+LXX+agQVTbYwi4GMfx59VJqdBF 74k11S54p10pkR7XIq0r5ymiwoSnToMUiBYtadWbUW/yR96MGv2Ebq72rX3VHJh+GrmE LbAoMoxAo88lhb9AlGvyVsrNwNKdyU3TMuyV+13DZ8SMX7hYsj60xlz6ZFRqH+QUWoGK XbIwVfNMfvNFqCF8lXxosbZi718Bmb+9bex7UVXqu1zFergheSdCyt0G5PdubqOIhKB4 807w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=XYJvVo3ty/MNRHJIfnnGaGtxeTdyVW4zLGsuWda4qyw=; b=mUpaiYbluAeUwQhCbx8vSE0US2n1a7YihhG6QZNpBTruWFP8mhn5Ht9zcAM3qWpntv f4ojzWemLwzfFI2N81It66yT/U/MaxhTtmALvpXidcENTouoJYB72TirXNvf8ORSWlna Kd/VABCLSSoycYIoPwlqAtJTT/e5RgOnzq92HC4rm+8vD7y+d0WCH+/e4GInF+g0xBjZ NQDx1inRwtlsDDY7vRMahDTBj+kJTh/jU3jLo1jIf5HFLs2KLlu6VDbDQiYlqV5dVav0 GJXfd7uKWzXgwsgJuIszqflN8mA/JigNzLTUcOye7zIz8+OHh97OwrTvsX9+1yclkuHo NBBA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id v10si60637wrr.3.2020.11.11.04.03.51 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2020 04:03:51 -0800 (PST) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CWNgC01lQz1rwZx; Wed, 11 Nov 2020 13:03:51 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CWNgB70dKz1qwTp; Wed, 11 Nov 2020 13:03:50 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id oO62SaQXlzGr; Wed, 11 Nov 2020 13:03:50 +0100 (CET) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Wed, 11 Nov 2020 13:03:50 +0100 (CET) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 4A71945427AA; Wed, 11 Nov 2020 13:03:49 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id iPlDNj5T5mne; Wed, 11 Nov 2020 13:03:45 +0100 (CET) Received: from paperino.fritz.box (paperino.fritz.box [192.168.178.64]) by babic.homelinux.org (Postfix) with ESMTP id DE29D45427AB; Wed, 11 Nov 2020 13:03:32 +0100 (CET) From: Stefano Babic To: swupdate@googlegroups.com Cc: Stefano Babic Subject: [swupdate] [PATCH 5/6] Drop REQ_INSTALL_DRYRUN Date: Wed, 11 Nov 2020 13:03:26 +0100 Message-Id: <20201111120327.607444-6-sbabic@denx.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201111120327.607444-1-sbabic@denx.de> References: <20201111120327.607444-1-sbabic@denx.de> MIME-Version: 1.0 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , This becomes obsolete because the dry-run option becomes an option in the request install (swupdate_request) structure. Signed-off-by: Stefano Babic --- core/network_thread.c | 1 - doc/source/swupdate-ipc.rst | 2 +- include/network_ipc.h | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/core/network_thread.c b/core/network_thread.c index a3c10a0..6757cc4 100644 --- a/core/network_thread.c +++ b/core/network_thread.c @@ -345,7 +345,6 @@ void *network_thread (void *data) break; case REQ_INSTALL: - case REQ_INSTALL_DRYRUN: TRACE("Incoming network request: processing..."); if (instp->status == IDLE) { instp->fd = ctrlconnfd; diff --git a/doc/source/swupdate-ipc.rst b/doc/source/swupdate-ipc.rst index d9390c9..a3ccb13 100644 --- a/doc/source/swupdate-ipc.rst +++ b/doc/source/swupdate-ipc.rst @@ -42,7 +42,7 @@ The exchanged packets are described in network_ipc.h Where the fields have the meaning: - magic : a magic number as simple proof of the packet -- type : one of REQ_INSTALL, REQ_INSTALL_DRYRUN, ACK, NACK, +- type : one of REQ_INSTALL, ACK, NACK, GET_STATUS, POST_UPDATE, SWUPDATE_SUBPROCESS, SET_AES_KEY - msgdata : a buffer used by the client to send the image or by SWUpdate to report back notifications and status. diff --git a/include/network_ipc.h b/include/network_ipc.h index 9558183..2e6f75d 100644 --- a/include/network_ipc.h +++ b/include/network_ipc.h @@ -33,7 +33,6 @@ typedef enum { GET_STATUS, POST_UPDATE, SWUPDATE_SUBPROCESS, - REQ_INSTALL_DRYRUN, SET_AES_KEY, SET_UPDATE_STATE, /* set bootloader ustate */ REQ_INSTALL_EXT