Message ID | 20200115151009.4283-1-sbabic@denx.de |
---|---|
State | Accepted |
Headers | show
Return-Path: <swupdate+bncBCXPLOXJ6IKRBWGW7TYAKGQEGLT5ZQY@googlegroups.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=googlegroups.com (client-ip=2a00:1450:4864:20::53b; helo=mail-ed1-x53b.google.com; envelope-from=swupdate+bncbcxploxj6ikrbwgw7tyakgqeglt5zqy@googlegroups.com; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=googlegroups.com header.i=@googlegroups.com header.a=rsa-sha256 header.s=20161025 header.b=kMoB1pWw; dkim-atps=neutral Received: from mail-ed1-x53b.google.com (mail-ed1-x53b.google.com [IPv6:2a00:1450:4864:20::53b]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 47yWHR5Xndz9sRV for <incoming@patchwork.ozlabs.org>; Thu, 16 Jan 2020 02:20:49 +1100 (AEDT) Received: by mail-ed1-x53b.google.com with SMTP id f11sf11686146edy.22 for <incoming@patchwork.ozlabs.org>; Wed, 15 Jan 2020 07:20:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1579101645; cv=pass; d=google.com; s=arc-20160816; b=of+KEJeBf1PuJCxuN/I232x83wT4C6/ttn23y/ZHUNmE4PKJ3jToFQheg+YJCpWms+ 7WWc/Pxbis1tUfsKVlzeUedppCInKIU8nkLNyXIdVOGOheACReV9psDkulGQAVFfAERL RvpiK5FlhC6e9h1oFJFQ/QjuvX15zcVChTno0zxiUFL5S74x3A0adcUyDTNLCOqWX3/G N/8a4pt9wNFNqkWURWVF5VyKKAohbj53h/HSP973/fqqZ/IaADNM0G70eyGnfoy3AToy Ek2Ldt8j11k75l703pTm6H0hmtmij/BmorkWMXW0eIfqNVsA1c938dMSCbqudi7XHcal aB4Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-unsubscribe:list-subscribe:list-archive:list-help:list-post :list-id:mailing-list:precedence:message-id:date:subject:cc:to:from :mime-version:sender:dkim-signature; bh=t8hYPi9VxAWZy0f8aDtokXudmMnUXxOCX8WoAKtFSWM=; b=ENRvp35str/oa2b8AJIcHDl5lwI3sgRAeaOtEmZxja04qEV7NhigU/BaZsi72gF4vL 7RY1wpCEYzb3QeSK0IqgC9mcospVBoBLo1tObKTtz3ESByJuGLkIH0+8FuVmg1Bt9dXj GMeqZHri8vCtRn3R+Uw/bzKQaX9BaFT0JsKE08pEVKzOAcJvL7AjGjFPVt8uwxX9bsbj N1+uUIe2yMIABzkoYYSD9TZiULf48WiR+AlG1DSQ768DKWMPJwPKoBVlyPsVqdsBfuzx pV1Lb05WeJn9oJ5H5k7ZK12h6iyTzre9VoKbiG1tV41jG474t2XZnrA/Y6Rn2/PCvhN9 d6qA== ARC-Authentication-Results: i=2; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlegroups.com; s=20161025; h=sender:mime-version:from:to:cc:subject:date:message-id :x-original-sender:x-original-authentication-results:precedence :mailing-list:list-id:list-post:list-help:list-archive :list-subscribe:list-unsubscribe; bh=t8hYPi9VxAWZy0f8aDtokXudmMnUXxOCX8WoAKtFSWM=; b=kMoB1pWw08PI9R45qhhQlPRs5zCdszzwhFd2SkrO+L+iKtJFfklKYT9Of2PJ/oIc6C jow5s+TOcdK1sGsFncKwavbNqMa742KfuLmVmgM2R3aqVGDCrCuC9fsDzCsGtVkwO9BD rDJRkdsZOieG3Y4QlIi4E61U5GamOyMoOLbb88UfUpniiPJsWH2dPWz1DIrBC1zvtf+i 07Z7kIsiJ5q2SDmsvmCCDW2RzyYn/ZNTyby+cAwLdQR499qkBLqqM4WtLkVDNXq4kMcO d3KoVlfnda1QMcEY3knCED+ODvRXjd0aT3sHUipLvbnLM6elsC7i761jAp4R0EUfGHm6 42zA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=sender:x-gm-message-state:mime-version:from:to:cc:subject:date :message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:x-spam-checked-in-group:list-post :list-help:list-archive:list-subscribe:list-unsubscribe; bh=t8hYPi9VxAWZy0f8aDtokXudmMnUXxOCX8WoAKtFSWM=; b=Oa5sKv/zNqvof2sFpqQTiBRpKsTxzAK1H3FnyKEm/0zxyiQ9Iai31fuHsyAOEO31i1 dKxeDKVUFP+Zp+G2vf6GK7XKDovPrWkBf6v2qtBZLhVDD0+9j6NlsGps/2eqAWKV/voc bmcLzbCvTJ37vQt0Htx7yQVjeIbTxs3va+ET5aeTYr7UXtNTgh4YUs/t3wSl3Dmbbrcz cRaTRE9XklAbwLbqZfFk+mIu+4Gle5oYvSIuFS8TquxN2wOCSdzUutirsxE2kx63o562 wB+cl1awRfLgKFlNsbC4H3eR6HRFSjJF86kufCyfK0rAY4dN3nWCp0FlaJbrcBnHTO6f 8iZA== Sender: swupdate@googlegroups.com X-Gm-Message-State: APjAAAXzXyP02HjmYIvL3tH4Mqm9MqV1rzrxmFgFGy966saErHJlfjSa cuA8E0ZJVPDgNyrrr6GpotA= X-Google-Smtp-Source: APXvYqx5K6Q/rgRNYToRMDkzfrYILooXLYkgyQmVdsRM1N8eF4W58XLKwdLGZHANe5wefIYx/9TjZw== X-Received: by 2002:a17:906:768f:: with SMTP id o15mr26227533ejm.353.1579101016472; Wed, 15 Jan 2020 07:10:16 -0800 (PST) MIME-Version: 1.0 X-BeenThere: swupdate@googlegroups.com Received: by 2002:a50:fb11:: with SMTP id d17ls4273197edq.13.gmail; Wed, 15 Jan 2020 07:10:15 -0800 (PST) X-Received: by 2002:a05:6402:3047:: with SMTP id bu7mr30385235edb.44.1579101015560; Wed, 15 Jan 2020 07:10:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1579101015; cv=none; d=google.com; s=arc-20160816; b=CE992bGaM+Db+10zcJol51RAouMf6yfSHh0HBLQRdGDhNi50lxSDXaJOHucB6tjMqE 9Cl4f/vqaJ21ufGHNczHlPEOqAhV5s+5Pe7v5nnpHuFLWyf7X6yGz5Yy6ysAXgLwDQHp hPeDhnKREeDCTIvfFqY2+z09/slChEWDDhA1elkDg3ZLU0b3L9ydkk+PwDzo0aqLhKtz 86YSJtQvsRVCvpmrHY+qxE+HYJCR5Ls8w4+Tfc7rcTcTSjq3spLQP2YE3HvPIrROTjhV cZ+T/r6ubThcjcEZwTC9Iiy4xv73HJ0+ALRiBoiLlq8B/ji5SE1pP/fUYyl0miCvNPgo s2vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=NHKo//fIdExUvCP9Ijl1D1vrwAi9aOxQYwtOZfQkzhs=; b=zXZagRa5V0+GcqwVhjEF6kZBrctusZfcm0ztNNVeCyCz/UL/jz+PbY63aGDL7/hYHp NPtin6J2M7vGwIPw0e+7ZLyBIo3XBLa/4u9NBCQPCOEk3oxZfu7RdEtgJolDIbFUaVlC Tq8L4gMXdD8X88YsEX0zK7HevAVqpm8MHP49VK1Q8jJlbOw085ynn3qKOib5yBkXRtVC gOU7Dt5fRdTaADGmJHLkCS1gGlPEY8zlQwGh9DRc4OT6FRX9OnR2UvS5aMU+0ae2TGE1 1ojpwfaeixGuqer+ldtgmV1T4rCfiTuIRSoiJmWCLOzdJ81VHM5TZme4XUpEArSjL/a5 wSAw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id n21si749822eja.0.2020.01.15.07.10.15 for <swupdate@googlegroups.com> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jan 2020 07:10:15 -0800 (PST) Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47yW3C25SZz1rfQ7; Wed, 15 Jan 2020 16:10:15 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47yW3C1vZNz1qtdy; Wed, 15 Jan 2020 16:10:15 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id TBo15ORhqfA6; Wed, 15 Jan 2020 16:10:14 +0100 (CET) Received: from babic.homelinux.org (host-88-217-136-221.customer.m-online.net [88.217.136.221]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPS; Wed, 15 Jan 2020 16:10:14 +0100 (CET) Received: from localhost (mail.babic.homelinux.org [127.0.0.1]) by babic.homelinux.org (Postfix) with ESMTP id 769F24540547; Wed, 15 Jan 2020 16:10:14 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at babic.homelinux.org Received: from babic.homelinux.org ([IPv6:::1]) by localhost (mail.babic.homelinux.org [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 3z9M4UYfbBwq; Wed, 15 Jan 2020 16:10:12 +0100 (CET) Received: from papero.fritz.box (papero.fritz.box [192.168.178.132]) by babic.homelinux.org (Postfix) with ESMTP id 684774540494; Wed, 15 Jan 2020 16:10:11 +0100 (CET) From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de> Subject: [swupdate] [PATCH] swupdate_file_setnonblock: simply returns from fcntl Date: Wed, 15 Jan 2020 16:10:09 +0100 Message-Id: <20200115151009.4283-1-sbabic@denx.de> X-Mailer: git-send-email 2.17.1 X-Original-Sender: sbabic@denx.de X-Original-Authentication-Results: gmr-mx.google.com; spf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) smtp.mailfrom=sbabic@denx.de Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com List-ID: <swupdate.googlegroups.com> X-Spam-Checked-In-Group: swupdate@googlegroups.com X-Google-Group-Id: 605343134186 List-Post: <https://groups.google.com/group/swupdate/post>, <mailto:swupdate@googlegroups.com> List-Help: <https://groups.google.com/support/>, <mailto:swupdate+help@googlegroups.com> List-Archive: <https://groups.google.com/group/swupdate List-Subscribe: <https://groups.google.com/group/swupdate/subscribe>, <mailto:swupdate+subscribe@googlegroups.com> List-Unsubscribe: <mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>, <https://groups.google.com/group/swupdate/subscribe> |
Series |
swupdate_file_setnonblock: simply returns from fcntl
|
expand
|
diff --git a/core/util.c b/core/util.c index f4aee4f..3c6cde5 100644 --- a/core/util.c +++ b/core/util.c @@ -747,6 +747,6 @@ int swupdate_file_setnonblock(int fd, bool block) else flags &= ~O_NONBLOCK; - return !(fcntl(fd, F_SETFL, flags) == -1); + return fcntl(fd, F_SETFL, flags); }
Fucntion returns the wrong status causing a warning during an update - fix the return logic. Signed-off-by: Stefano Babic <sbabic@denx.de> --- core/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)