[meta-swupdate] systemd waiting long to shutdown SWUpdate

Message ID	20191008092705.2094-1-sbabic@denx.de
State	Accepted
Headers	show Return-Path: <swupdate+bncBCXPLOXJ6IKRB4VM6HWAKGQEWS7SYMQ@googlegroups.com> Sender: swupdate@googlegroups.com MIME-Version: 1.0 Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied by best guess record for domain of sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; From: Stefano Babic <sbabic@denx.de> To: swupdate@googlegroups.com Cc: Stefano Babic <sbabic@denx.de>, Johannes Schrimpf <johannes.schrimpf@blueye.no> Subject: [swupdate] [meta-swupdate][PATCH] systemd waiting long to shutdown SWUpdate Date: Tue, 8 Oct 2019 11:27:05 +0200 Message-Id: <20191008092705.2094-1-sbabic@denx.de> Content-Type: text/plain; charset="UTF-8" Precedence: list Mailing-list: list swupdate@googlegroups.com; contact swupdate+owners@googlegroups.com
Series	[meta-swupdate] systemd waiting long to shutdown SWUpdate \| expand [meta-swupdate] systemd waiting long to shutdown SWUpdate

Message ID

20191008092705.2094-1-sbabic@denx.de

State

Accepted

Headers

Sender: swupdate@googlegroups.com
MIME-Version: 1.0
Received-SPF: neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither
	permitted nor denied by best guess record for domain of
	sbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; 
From: Stefano Babic <sbabic@denx.de>
To: swupdate@googlegroups.com
Cc: Stefano Babic <sbabic@denx.de>,
	Johannes Schrimpf <johannes.schrimpf@blueye.no>
Subject: [swupdate] [meta-swupdate][PATCH] systemd waiting long to shutdown
	SWUpdate
Date: Tue,  8 Oct 2019 11:27:05 +0200
Message-Id: <20191008092705.2094-1-sbabic@denx.de>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Mailing-list: list swupdate@googlegroups.com;
	contact swupdate+owners@googlegroups.com

Series

[meta-swupdate] systemd waiting long to shutdown SWUpdate | expand

Commit Message

Stefano Babic Oct. 8, 2019, 9:27 a.m. UTC

Under certain situations, systemd is waiting for a long time that
SWUpdate stops. SWUpdate has in fact its own process control management
to monitor its own processes and SIGTERM cannot be sent to the children
by systemd. Add KillMode=mixed option to let SWUpdate to make its job:
systemd will send SIGTERM just to SWUPdate's main process.

Signed-off-by: Stefano Babic <sbabic@denx.de>
Signed-off-by: Johannes Schrimpf <johannes.schrimpf@blueye.no>
---
 recipes-support/swupdate/swupdate/swupdate.service | 1 +
 1 file changed, 1 insertion(+)

diff --git a/recipes-support/swupdate/swupdate/swupdate.service b/recipes-support/swupdate/swupdate/swupdate.service
index 59f6c10..b585616 100644
--- a/recipes-support/swupdate/swupdate/swupdate.service
+++ b/recipes-support/swupdate/swupdate/swupdate.service
@@ -7,6 +7,7 @@  Documentation=https://sbabic.github.io/swupdate
 ExecStartPre=-/usr/bin/swupdate-env
 EnvironmentFile=-/tmp/swupdate.env
 ExecStart=/usr/bin/swupdate -v -w "-r /www" $SWUPDATE_EXTRA_ARGS
+KillMode=mixed
 
 [Install]
 WantedBy=multi-user.target

[meta-swupdate] systemd waiting long to shutdown SWUpdate

Commit Message

Patch