diff mbox series

parser: don't use printf() for logging

Message ID 20170920070035.10778-1-christian.storm@siemens.com
State Accepted
Headers show
Series parser: don't use printf() for logging | expand

Commit Message

Storm, Christian Sept. 20, 2017, 7 a.m. UTC 
Signed-off-by: Christian Storm <christian.storm@siemens.com>
---
 parser/parser.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefano Babic Sept. 20, 2017, 7:42 a.m. UTC | #1 
On 20/09/2017 09:00, Christian Storm wrote:
> Signed-off-by: Christian Storm <christian.storm@siemens.com>
> ---
>  parser/parser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/parser/parser.c b/parser/parser.c
> index c962b59..a41bc24 100644
> --- a/parser/parser.c
> +++ b/parser/parser.c
> @@ -623,7 +623,7 @@ int parse_cfg (struct swupdate_cfg *swcfg, const char *filename)
>  		return -1;
>  	} else {
>  		strncpy(swcfg->version, str, sizeof(swcfg->version));
> -		fprintf(stdout, "Version %s\n", swcfg->version);
> +		TRACE("Version %s", swcfg->version);
>  	}
>  	snprintf(node, sizeof(node), "%s.embedded-script",
>  			NODEROOT);
> 

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano
diff mbox series

Patch

diff --git a/parser/parser.c b/parser/parser.c
index c962b59..a41bc24 100644
--- a/parser/parser.c
+++ b/parser/parser.c
@@ -623,7 +623,7 @@  int parse_cfg (struct swupdate_cfg *swcfg, const char *filename)
 		return -1;
 	} else {
 		strncpy(swcfg->version, str, sizeof(swcfg->version));
-		fprintf(stdout, "Version %s\n", swcfg->version);
+		TRACE("Version %s", swcfg->version);
 	}
 	snprintf(node, sizeof(node), "%s.embedded-script",
 			NODEROOT);