diff mbox series

[meta-swupdate,v3,4/4] Improve signcmd for CUSTOM signing in swupdate-common class

Message ID 1637668337-30416-1-git-send-email-jyothik41rao@gmail.com
State Accepted
Headers show
Series None | expand

Commit Message

Jyothi K Nov. 23, 2021, 11:52 a.m. UTC 
Signed-off-by: Jyothi <jyothik41rao@gmail.com>
---
 classes/swupdate-common.bbclass | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

Comments

Stefano Babic Nov. 23, 2021, 1:54 p.m. UTC | #1 
On 23.11.21 12:52, Jyothi wrote:
> Signed-off-by: Jyothi <jyothik41rao@gmail.com>
> ---
>   classes/swupdate-common.bbclass | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/classes/swupdate-common.bbclass b/classes/swupdate-common.bbclass
> index bbb68b3..7d06c96 100644
> --- a/classes/swupdate-common.bbclass
> +++ b/classes/swupdate-common.bbclass
> @@ -260,7 +260,11 @@ def prepare_sw_description(d):
>           sw_desc =  os.path.join(s, 'sw-description.plain' if encrypt else 'sw-description')
>   
>           if signing == "CUSTOM":
> -            signcmd = d.getVar('SWUPDATE_SIGN_TOOL', True)
> +            signcmd = []
> +            sign_tool = d.getVar('SWUPDATE_SIGN_TOOL', True)
> +            signtool = sign_tool.split()
> +            for i in range(len(signtool)):
> +                signcmd.append(signtool[i])
>               if not signcmd:
>                   bb.fatal("Custom SWUPDATE_SIGN_TOOL is not given")
>           elif signing == "RSA":
> 

Applied to :

    8eb187c..dcf6616  dunfell -> dunfell
    f6070a3..0182a66  hardknott -> hardknott
    22f5f5b..6fd0f4c  honister -> honister
    3d7bb73..f4734e0  master -> master


Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/classes/swupdate-common.bbclass b/classes/swupdate-common.bbclass
index bbb68b3..7d06c96 100644
--- a/classes/swupdate-common.bbclass
+++ b/classes/swupdate-common.bbclass
@@ -260,7 +260,11 @@  def prepare_sw_description(d):
         sw_desc =  os.path.join(s, 'sw-description.plain' if encrypt else 'sw-description')
 
         if signing == "CUSTOM":
-            signcmd = d.getVar('SWUPDATE_SIGN_TOOL', True)
+            signcmd = []
+            sign_tool = d.getVar('SWUPDATE_SIGN_TOOL', True)
+            signtool = sign_tool.split()
+            for i in range(len(signtool)):
+                signcmd.append(signtool[i])
             if not signcmd:
                 bb.fatal("Custom SWUPDATE_SIGN_TOOL is not given")
         elif signing == "RSA":