| Message ID | 1558110205-32750-1-git-send-email-pjtexier@koncepto.io |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [libubootenv] libubootenv: bump SRCREV | expand |
Le 17/05/2019 à 18:23, Pierre-Jean Texier a écrit : > This includes the following changes: > > edb580a fw_printenv: set 'u-boot-initial-env' file as default > d630076 fw_printenv: remove declaration in for loop > > Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> > --- > recipes-bsp/libubootenv/libubootenv_0.1.bb | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/recipes-bsp/libubootenv/libubootenv_0.1.bb b/recipes-bsp/libubootenv/libubootenv_0.1.bb > index 6c593a1..a7b33c4 100644 > --- a/recipes-bsp/libubootenv/libubootenv_0.1.bb > +++ b/recipes-bsp/libubootenv/libubootenv_0.1.bb > @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/LGPL-2.1;md5=1a6d268fd218675ffe > SECTION = "libs" > > SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https" > -SRCREV = "8a7d4030bcb106de11632e85b6a0e7b7d4cb47af" > +SRCREV = "edb580a42e46f76543edd0d6fd603881c6294eca" > PV_append = "+git${SRCPV}" > > S = "${WORKDIR}/git" Oops, Not [libubootenv], [meta-swupdate] for sure. /Pierre-Jean
On 17/05/19 18:40, 'Pierre-Jean Texier' via swupdate wrote: > > > Le 17/05/2019 à 18:23, Pierre-Jean Texier a écrit : >> This includes the following changes: >> >> edb580a fw_printenv: set 'u-boot-initial-env' file as default >> d630076 fw_printenv: remove declaration in for loop >> >> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> >> --- >> recipes-bsp/libubootenv/libubootenv_0.1.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/recipes-bsp/libubootenv/libubootenv_0.1.bb >> b/recipes-bsp/libubootenv/libubootenv_0.1.bb >> index 6c593a1..a7b33c4 100644 >> --- a/recipes-bsp/libubootenv/libubootenv_0.1.bb >> +++ b/recipes-bsp/libubootenv/libubootenv_0.1.bb >> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = >> "file://${COMMON_LICENSE_DIR}/LGPL-2.1;md5=1a6d268fd218675ffe >> SECTION = "libs" >> SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https" >> -SRCREV = "8a7d4030bcb106de11632e85b6a0e7b7d4cb47af" >> +SRCREV = "edb580a42e46f76543edd0d6fd603881c6294eca" >> PV_append = "+git${SRCPV}" >> S = "${WORKDIR}/git" > > Oops, Not [libubootenv], [meta-swupdate] for sure. > Yes, of course, merged. Best regards, Stefano Babic
Hi Stefano, > >> This includes the following changes: > >> > >> edb580a fw_printenv: set 'u-boot-initial-env' file as default > >> d630076 fw_printenv: remove declaration in for loop > >> > >> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> > >> --- > >> recipes-bsp/libubootenv/libubootenv_0.1.bb | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/recipes-bsp/libubootenv/libubootenv_0.1.bb > >> b/recipes-bsp/libubootenv/libubootenv_0.1.bb > >> index 6c593a1..a7b33c4 100644 > >> --- a/recipes-bsp/libubootenv/libubootenv_0.1.bb > >> +++ b/recipes-bsp/libubootenv/libubootenv_0.1.bb > >> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = > >> "file://${COMMON_LICENSE_DIR}/LGPL- > 2.1;md5=1a6d268fd218675ffe > >> SECTION = "libs" > >> SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https" > >> -SRCREV = "8a7d4030bcb106de11632e85b6a0e7b7d4cb47af" > >> +SRCREV = "edb580a42e46f76543edd0d6fd603881c6294eca" > >> PV_append = "+git${SRCPV}" > >> S = "${WORKDIR}/git" > > > > Oops, Not [libubootenv], [meta-swupdate] for sure. > > > > > Yes, of course, merged. I am confused by the volatility of the libubootenv v0.1 tag. In https://github.com/sbabic/libubootenv it was first set to e67ce38 and then later it was moved to 8a7d403. Now the libubootenv_0.1.bb recipe virtually moves the tag even further to edb580a. Can you shed some light on the strategy? I am currently preparing a software release and would like to use an officially tagged version of libubootenv. Preferably this would be 8a7d403. Greetings, Mark Building Technologies, Panel Software Fire (BT-FIR/ENG1) Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 Aufsichtsratsvorsitzender: Christian Fischer; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster
Hi Jonas, On Mon, May 20, 2019 at 2:35 PM 'Jonas Mark (BT-FIR/ENG1)' via swupdate <swupdate@googlegroups.com> wrote: > > Hi Stefano, > > > >> This includes the following changes: > > >> > > >> edb580a fw_printenv: set 'u-boot-initial-env' file as default > > >> d630076 fw_printenv: remove declaration in for loop > > >> > > >> Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> > > >> --- > > >> recipes-bsp/libubootenv/libubootenv_0.1.bb | 2 +- > > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > >> > > >> diff --git a/recipes-bsp/libubootenv/libubootenv_0.1.bb > > >> b/recipes-bsp/libubootenv/libubootenv_0.1.bb > > >> index 6c593a1..a7b33c4 100644 > > >> --- a/recipes-bsp/libubootenv/libubootenv_0.1.bb > > >> +++ b/recipes-bsp/libubootenv/libubootenv_0.1.bb > > >> @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = > > >> "file://${COMMON_LICENSE_DIR}/LGPL- > > 2.1;md5=1a6d268fd218675ffe > > >> SECTION = "libs" > > >> SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https" > > >> -SRCREV = "8a7d4030bcb106de11632e85b6a0e7b7d4cb47af" > > >> +SRCREV = "edb580a42e46f76543edd0d6fd603881c6294eca" > > >> PV_append = "+git${SRCPV}" > > >> S = "${WORKDIR}/git" > > > > > > Oops, Not [libubootenv], [meta-swupdate] for sure. > > > > > > > > > Yes, of course, merged. > > I am confused by the volatility of the libubootenv v0.1 tag. > > In https://github.com/sbabic/libubootenv it was first set to e67ce38 and > then later it was moved to 8a7d403. Now the libubootenv_0.1.bb recipe > virtually moves the tag even further to edb580a. > > Can you shed some light on the strategy? In the recipe we have added a: PV_append = "+git${SRCPV}" https://github.com/sbabic/meta-swupdate/blob/master/recipes-bsp/libubootenv/libubootenv_0.1.bb#L14 that will append git revision to the tagged package version. > > I am currently preparing a software release and would like to use an > officially tagged version of libubootenv. Preferably this would be > 8a7d403. 8a7d403 is not tip of master anymore, so it doesn't make much sense to tag a past version, unless there's a valid reason. The thing is standalone libubooenv is still a young project, you need to decide if "nice" release numbers have value over having the latest fixes applied in master. Sure the maintainer can decide to tag a new release, but at some point a new important fix will turn up anyway. Regards, Diego Rondini Sr. Embedded Engineer Kynetics www.kynetics.com
Hi Diego, > > I am confused by the volatility of the libubootenv v0.1 tag. > > > > In https://github.com/sbabic/libubootenv it was first set to e67ce38 > > and then later it was moved to 8a7d403. Now the libubootenv_0.1.bb > > recipe virtually moves the tag even further to edb580a. > > > > Can you shed some light on the strategy? > > In the recipe we have added a: > PV_append = "+git${SRCPV}" > https://github.com/sbabic/meta-swupdate/blob/master/recipes- > bsp/libubootenv/libubootenv_0.1.bb#L14 > that will append git revision to the tagged package version. > > > > > I am currently preparing a software release and would like to use an > > officially tagged version of libubootenv. Preferably this would be > > 8a7d403. > > 8a7d403 is not tip of master anymore, so it doesn't make much sense to > tag a past version, unless there's a valid reason. > > The thing is standalone libubooenv is still a young project, you need to > decide if "nice" release numbers have value over having the latest fixes > applied in master. > Sure the maintainer can decide to tag a new release, but at some point a > new important fix will turn up anyway. OK, I understand PV_append and the rapid development. Why doesn't the well-established strategy to add a libubootenv_git.bb recipe which either builds HEAD or a semi-fixed recent version work here? I think so far Stefano used the latter. https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/swupdate/swupdate_git.bb None the less I hope that the libubootenv v0.1 tag will not move any more. I think moving version tags are really unexpected. Regards, Mark Building Technologies, Panel Software Fire (BT-FIR/ENG1) Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118 Aufsichtsratsvorsitzender: Christian Fischer; Geschäftsführung: Tanja Rückert, Andreas Bartz, Thomas Quante, Bernhard Schuster
Hi Jonas, On Mon, May 20, 2019 at 3:48 PM Jonas Mark (BT-FIR/ENG1) <Mark.Jonas@de.bosch.com> wrote: > > <snip> > > > > > 8a7d403 is not tip of master anymore, so it doesn't make much sense to > > tag a past version, unless there's a valid reason. > > > > The thing is standalone libubooenv is still a young project, you need to > > decide if "nice" release numbers have value over having the latest fixes > > applied in master. > > Sure the maintainer can decide to tag a new release, but at some point a > > new important fix will turn up anyway. > > OK, I understand PV_append and the rapid development. > > Why doesn't the well-established strategy to add a libubootenv_git.bb > recipe which either builds HEAD or a semi-fixed recent version work > here? I think so far Stefano used the latter. > > https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/swupdate/swupdate_git.bb > swupdate is a much more mature project, so the idea may apply in the future to libubootenv too, but it seems premature right now. > None the less I hope that the libubootenv v0.1 tag will not move any > more. I think moving version tags are really unexpected. > I see the tag has actually moved on github, which is odd, especially as there is a "Release 0.1" commit: https://github.com/sbabic/libubootenv/commits/v0.1 I'll let Stefano reply about the tag. Regards, Diego Rondini Sr. Embedded Engineer Kynetics www.kynetics.com
Hi Mark, Diego, I am back from a business trip and I sumarize the discussion up now without answering to the single points: On 21/05/19 10:27, Diego Rondini wrote: > Hi Jonas, > > On Mon, May 20, 2019 at 3:48 PM Jonas Mark (BT-FIR/ENG1) > <Mark.Jonas@de.bosch.com> wrote: >> >> <snip> >> >>> >>> 8a7d403 is not tip of master anymore, so it doesn't make much sense to >>> tag a past version, unless there's a valid reason. >>> >>> The thing is standalone libubooenv is still a young project, you need to >>> decide if "nice" release numbers have value over having the latest fixes >>> applied in master. >>> Sure the maintainer can decide to tag a new release, but at some point a >>> new important fix will turn up anyway. >> >> OK, I understand PV_append and the rapid development. >> >> Why doesn't the well-established strategy to add a libubootenv_git.bb >> recipe which either builds HEAD or a semi-fixed recent version work >> here? I think so far Stefano used the latter. >> >> https://github.com/sbabic/meta-swupdate/blob/master/recipes-support/swupdate/swupdate_git.bb >> > > swupdate is a much more mature project, so the idea may apply in the > future to libubootenv too, but it seems premature right now. > >> None the less I hope that the libubootenv v0.1 tag will not move any >> more. I think moving version tags are really unexpected. >> > > I see the tag has actually moved on github, which is odd, especially > as there is a "Release 0.1" commit: > https://github.com/sbabic/libubootenv/commits/v0.1 > > I'll let Stefano reply about the tag. > The tag was never moved - moving a tag is weird and should never be done. The fact is, there was no tag at all when I put out commit e67ce380 with the description of a release. Because I got from you some fixes later that are better to have, I set the unique tag we have in libubootenv to the commit with these fixes, that is 8a7d4030. New development and fixes are merged as usual in FOSS project - they belong to target, they do not change the past. The issue comes because in meta-swupdate we must have two recipes, one for the released (libubootenv_0.1.bb) and one for the TOT. I will fix this with one patch to: - rename libubootenv_0.1.bb to libubootenv_git.bb - add a libubootenv_0.1.bb with a SRCREV pointing to the tag. Best regards, Stefano
Hi Stefano, On Wed, May 22, 2019 at 12:28 PM Stefano Babic <sbabic@denx.de> wrote: > > <snip> > > The tag was never moved - moving a tag is weird and should never be > done. The fact is, there was no tag at all when I put out commit > e67ce380 with the description of a release. Because I got from you some > fixes later that are better to have, I set the unique tag we have in > libubootenv to the commit with these fixes, that is 8a7d4030. I see, thanks for clarifying. The "Release 0.1" commit caused some confusion, as it's not the same thing as 0.1 tag. Thank you, Diego Rondini Sr. Embedded Engineer Kynetics www.kynetics.com
On 22/05/19 16:47, Diego Rondini wrote: > Hi Stefano, > > On Wed, May 22, 2019 at 12:28 PM Stefano Babic <sbabic@denx.de> wrote: >> >> <snip> >> >> The tag was never moved - moving a tag is weird and should never be >> done. The fact is, there was no tag at all when I put out commit >> e67ce380 with the description of a release. Because I got from you some >> fixes later that are better to have, I set the unique tag we have in >> libubootenv to the commit with these fixes, that is 8a7d4030. > > I see, thanks for clarifying. The "Release 0.1" commit caused some > confusion, as it's not the same thing as 0.1 tag. Agree, I will avoid this in future. Regards, Stefano
diff --git a/recipes-bsp/libubootenv/libubootenv_0.1.bb b/recipes-bsp/libubootenv/libubootenv_0.1.bb index 6c593a1..a7b33c4 100644 --- a/recipes-bsp/libubootenv/libubootenv_0.1.bb +++ b/recipes-bsp/libubootenv/libubootenv_0.1.bb @@ -10,7 +10,7 @@ LIC_FILES_CHKSUM = "file://${COMMON_LICENSE_DIR}/LGPL-2.1;md5=1a6d268fd218675ffe SECTION = "libs" SRC_URI = "git://github.com/sbabic/libubootenv;protocol=https" -SRCREV = "8a7d4030bcb106de11632e85b6a0e7b7d4cb47af" +SRCREV = "edb580a42e46f76543edd0d6fd603881c6294eca" PV_append = "+git${SRCPV}" S = "${WORKDIR}/git"
This includes the following changes: edb580a fw_printenv: set 'u-boot-initial-env' file as default d630076 fw_printenv: remove declaration in for loop Signed-off-by: Pierre-Jean Texier <pjtexier@koncepto.io> --- recipes-bsp/libubootenv/libubootenv_0.1.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)