| Message ID | 20211108160840.61647-1-adrian.freihofer@siemens.com |
|---|---|
| Headers | show |
| Series | fix build-time signing issues | expand |
On 08.11.21 17:08, Adrian Freihofer wrote: > Comparison to V1: > - Reduce amount of chagnes > - Fix an error related to the eSDK introduced by V1 > > Adrian Freihofer (2): > swupdate-common: improve signing > swupdate-image: use image link name > > classes/swupdate-common.bbclass | 54 ++++++++++++--------------------- > classes/swupdate-image.bbclass | 7 ++--- > 2 files changed, 22 insertions(+), 39 deletions(-) > Applied to : To github.com:sbabic/meta-swupdate.git 9659220..89d059e dunfell -> dunfell 0b4523b..cc07581 hardknott -> hardknott 3793af1..557b1b5 honister -> honister b935dff..01968a3 master -> master Best regards, Stefano Babic
Hello all,
After this update there is a build error w.r.t sign_tool
=============================================================================
meta-swupdate/classes/swupdate-common.bbclass', lineno: 264, function:
prepare_sw_description 0260: sw_desc = os.path.join(s,
'sw-description.plain' if encrypt else 'sw-description') 0261: 0262: if
signing == "CUSTOM": 0263: signcmd = d.getVar('SWUPDATE_SIGN_TOOL', True)
*** 0264: if not sign_tool: 0265: bb.fatal("Custom SWUPDATE_SIGN_TOOL is
not given") 0266: elif signing == "RSA": 0267: privkey =
d.getVar('SWUPDATE_PRIVATE_KEY', True) 0268: if not privkey: Exception:
NameError: name 'sign_tool' is not defined
===============================================================================
I think the sign_tool to be updated to signcmd.
please provide the fix to resolve build issues.
Thanks,
Jyothi
On Sunday, November 21, 2021 at 4:34:00 PM UTC+5:30 Stefano Babic wrote:
>
>
> On 08.11.21 17:08, Adrian Freihofer wrote:
> > Comparison to V1:
> > - Reduce amount of chagnes
> > - Fix an error related to the eSDK introduced by V1
> >
> > Adrian Freihofer (2):
> > swupdate-common: improve signing
> > swupdate-image: use image link name
> >
> > classes/swupdate-common.bbclass | 54 ++++++++++++---------------------
> > classes/swupdate-image.bbclass | 7 ++---
> > 2 files changed, 22 insertions(+), 39 deletions(-)
> >
>
> Applied to :
>
> To github.com:sbabic/meta-swupdate.git
> 9659220..89d059e dunfell -> dunfell
> 0b4523b..cc07581 hardknott -> hardknott
> 3793af1..557b1b5 honister -> honister
> b935dff..01968a3 master -> master
>
> Best regards,
> Stefano Babic
>
> --
> =====================================================================
> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: +49-8142-66989-53 <+49%208142%206698953> Fax: +49-8142-66989-80
> <+49%208142%206698980> Email: sba...@denx.de
> =====================================================================
>
Hi Jyothi, On 22.11.21 10:52, Jyothi K wrote: > Hello all, > > After this update there is a build error w.r.t sign_tool > > ============================================================================= > meta-swupdate/classes/swupdate-common.bbclass', lineno: 264, function: > prepare_sw_description 0260: sw_desc = os.path.join(s, > 'sw-description.plain' if encrypt else 'sw-description') 0261: 0262: if > signing == "CUSTOM": 0263: signcmd = d.getVar('SWUPDATE_SIGN_TOOL', > True) *** 0264: if not sign_tool: 0265: bb.fatal("Custom > SWUPDATE_SIGN_TOOL is not given") 0266: elif signing == "RSA": 0267: > privkey = d.getVar('SWUPDATE_PRIVATE_KEY', True) 0268: if not privkey: > Exception: NameError: name 'sign_tool' is not defined > =============================================================================== > I think the sign_tool to be updated to signcmd. > Agree. > please provide the fix to resolve build issues. > Could you send the patch, please ? Best regards, Stefanmo Babic > Thanks, > Jyothi > On Sunday, November 21, 2021 at 4:34:00 PM UTC+5:30 Stefano Babic wrote: > > > > On 08.11.21 17:08, Adrian Freihofer wrote: > > Comparison to V1: > > - Reduce amount of chagnes > > - Fix an error related to the eSDK introduced by V1 > > > > Adrian Freihofer (2): > > swupdate-common: improve signing > > swupdate-image: use image link name > > > > classes/swupdate-common.bbclass | 54 > ++++++++++++--------------------- > > classes/swupdate-image.bbclass | 7 ++--- > > 2 files changed, 22 insertions(+), 39 deletions(-) > > > > Applied to : > > To github.com:sbabic/meta-swupdate.git > 9659220..89d059e dunfell -> dunfell > 0b4523b..cc07581 hardknott -> hardknott > 3793af1..557b1b5 honister -> honister > b935dff..01968a3 master -> master > > Best regards, > Stefano Babic > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 <tel:+49%208142%206698953> Fax: > +49-8142-66989-80 <tel:+49%208142%206698980> Email: sba...@denx.de > ===================================================================== > > -- > You received this message because you are subscribed to the Google > Groups "swupdate" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to swupdate+unsubscribe@googlegroups.com > <mailto:swupdate+unsubscribe@googlegroups.com>. > To view this discussion on the web visit > https://groups.google.com/d/msgid/swupdate/490618e6-5b13-42f5-91b6-142822b3ec75n%40googlegroups.com > <https://groups.google.com/d/msgid/swupdate/490618e6-5b13-42f5-91b6-142822b3ec75n%40googlegroups.com?utm_medium=email&utm_source=footer>.