Message ID | e4585b03-3629-4bd7-a349-f5471ebd8685@web.de |
---|---|
State | New |
Headers | show |
Series | [v2] sparc: leon: grpci1: Use devm_platform_ioremap_resource() in grpci1_of_probe() | expand |
On 2024-02-06 16:40, Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Tue, 6 Feb 2024 16:30:15 +0100 > > A wrapper function is available since the commit 7945f929f1a77a1c8887a97ca07f87626858ff42 This line is needlessly long. Could you wrap it or shorten the SHA-1 ID? You don't need more than the first 12 characters of the SHA-1 ID. > ("drivers: provide devm_platform_ioremap_resource()"). > > * Thus reuse existing functionality instead of keeping duplicate source code. The same goes for this one. Please keep the width of the commit description within 75 characters. > * Delete a local variable which became unnecessary with this refactoring. > > > This issue was transformed by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Apart from that the patch looks good. Thanks, Andreas
diff --git a/arch/sparc/kernel/leon_pci_grpci1.c b/arch/sparc/kernel/leon_pci_grpci1.c index 8700a0e3b0df..a01ecee18e1e 100644 --- a/arch/sparc/kernel/leon_pci_grpci1.c +++ b/arch/sparc/kernel/leon_pci_grpci1.c @@ -516,7 +516,6 @@ static int grpci1_of_probe(struct platform_device *ofdev) int err, len; const int *tmp; u32 cfg, size, err_mask; - struct resource *res; if (grpci1priv) { dev_err(&ofdev->dev, "only one GRPCI1 supported\n"); @@ -537,8 +536,7 @@ static int grpci1_of_probe(struct platform_device *ofdev) priv->dev = &ofdev->dev; /* find device register base address */ - res = platform_get_resource(ofdev, IORESOURCE_MEM, 0); - regs = devm_ioremap_resource(&ofdev->dev, res); + regs = devm_platform_ioremap_resource(ofdev, 0); if (IS_ERR(regs)) return PTR_ERR(regs);