| Message ID | 20260927212913.3237082-2-stian@itx.no |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/2] sparc64: increase kernel thread stack size to 32K | expand |
On 2026-09-27 23:29, Stian Halseth wrote: > Commit 15b9350a177b ("sparc64: Only support 4MB huge pages and 8KB > base pages.") made 8K the only base page size, so PAGE_SHIFT is > always 13 here and the else branches have been dead since. Remove > them. > > Fixes: 15b9350a177b ("sparc64: Only support 4MB huge pages and 8KB base pages.") > Suggested-by: Andreas Larsson <andreas@gaisler.com> > Signed-off-by: Stian Halseth <stian@itx.no> > --- > arch/sparc/include/asm/thread_info_64.h | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h > --- a/arch/sparc/include/asm/thread_info_64.h > +++ b/arch/sparc/include/asm/thread_info_64.h > @@ -99,13 +99,8 @@ > #define FAULT_CODE_BLKCOMMIT 0x10 /* Use blk-commit ASI in copy_page */ > #define FAULT_CODE_BAD_RA 0x20 /* Bad RA for sun4v */ > > -#if PAGE_SHIFT == 13 > #define THREAD_SIZE (4*PAGE_SIZE) > #define THREAD_SHIFT (PAGE_SHIFT + 2) > -#else /* PAGE_SHIFT == 13 */ > -#define THREAD_SIZE PAGE_SIZE > -#define THREAD_SHIFT PAGE_SHIFT > -#endif /* PAGE_SHIFT == 13 */ > > /* > * macros/functions for gaining access to the thread information structure > @@ -128,11 +123,7 @@ > #endif > > /* thread information allocation */ > -#if PAGE_SHIFT == 13 > #define THREAD_SIZE_ORDER 2 > -#else /* PAGE_SHIFT == 13 */ > -#define THREAD_SIZE_ORDER 0 > -#endif /* PAGE_SHIFT == 13 */ > > #define __thread_flag_byte_ptr(ti) \ > ((unsigned char *)(&((ti)->flags))) > -- > 2.53.0 Reviewed-by: Andreas Larsson <andreas@gaisler.com> Picking these two up to my for-next. Thanks, Andreas
diff --git a/arch/sparc/include/asm/thread_info_64.h b/arch/sparc/include/asm/thread_info_64.h --- a/arch/sparc/include/asm/thread_info_64.h +++ b/arch/sparc/include/asm/thread_info_64.h @@ -99,13 +99,8 @@ #define FAULT_CODE_BLKCOMMIT 0x10 /* Use blk-commit ASI in copy_page */ #define FAULT_CODE_BAD_RA 0x20 /* Bad RA for sun4v */ -#if PAGE_SHIFT == 13 #define THREAD_SIZE (4*PAGE_SIZE) #define THREAD_SHIFT (PAGE_SHIFT + 2) -#else /* PAGE_SHIFT == 13 */ -#define THREAD_SIZE PAGE_SIZE -#define THREAD_SHIFT PAGE_SHIFT -#endif /* PAGE_SHIFT == 13 */ /* * macros/functions for gaining access to the thread information structure @@ -128,11 +123,7 @@ #endif /* thread information allocation */ -#if PAGE_SHIFT == 13 #define THREAD_SIZE_ORDER 2 -#else /* PAGE_SHIFT == 13 */ -#define THREAD_SIZE_ORDER 0 -#endif /* PAGE_SHIFT == 13 */ #define __thread_flag_byte_ptr(ti) \ ((unsigned char *)(&((ti)->flags)))
Commit 15b9350a177b ("sparc64: Only support 4MB huge pages and 8KB base pages.") made 8K the only base page size, so PAGE_SHIFT is always 13 here and the else branches have been dead since. Remove them. Fixes: 15b9350a177b ("sparc64: Only support 4MB huge pages and 8KB base pages.") Suggested-by: Andreas Larsson <andreas@gaisler.com> Signed-off-by: Stian Halseth <stian@itx.no> --- arch/sparc/include/asm/thread_info_64.h | 10 ---------- 1 file changed, 10 deletions(-) -- 2.53.0