| Message ID | 20240224-sam-fix-sparc32-all-builds-v2-3-1f186603c5c4@ravnborg.org |
|---|---|
| State | New |
| Headers | show |
| Series | sparc32: build fixes for all{yes,mod}config builds | expand |
Hi Sam, devnull+sam.ravnborg.org@kernel.org wrote on Sat, 24 Feb 2024 18:42:24 +0100: > From: Sam Ravnborg <sam@ravnborg.org> > > This fixes the following warning: > sun_uflash.c:50:5: error: no previous prototype for 'uflash_devinit' > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally") > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested > Cc: Andreas Larsson <andreas@gaisler.com> > Cc: "David S. Miller" <davem@davemloft.net> I was about to take this but linux-mtd is not Cced, so I'm letting this to the Sparc maintainers. Please resend to the mtd list if I need to take it. Acked-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks, Miquèl
On 2024-02-24 18:42, Sam Ravnborg via B4 Relay wrote: > From: Sam Ravnborg <sam@ravnborg.org> > > This fixes the following warning: > sun_uflash.c:50:5: error: no previous prototype for 'uflash_devinit' > > Signed-off-by: Sam Ravnborg <sam@ravnborg.org> > Fixes: 0fcb70851fbf ("Makefile.extrawarn: turn on missing-prototypes globally") > Reviewed-by: Randy Dunlap <rdunlap@infradead.org> > Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested > Cc: Andreas Larsson <andreas@gaisler.com> > Cc: "David S. Miller" <davem@davemloft.net> > --- > drivers/mtd/maps/sun_uflash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Andreas Larsson <andreas@gaisler.com> Picking this up to my for-next. Thanks, Andreas
diff --git a/drivers/mtd/maps/sun_uflash.c b/drivers/mtd/maps/sun_uflash.c index f58cfb15d6e8..b69dade3f7ad 100644 --- a/drivers/mtd/maps/sun_uflash.c +++ b/drivers/mtd/maps/sun_uflash.c @@ -47,7 +47,7 @@ struct map_info uflash_map_templ = { .bankwidth = UFLASH_BUSWIDTH, }; -int uflash_devinit(struct platform_device *op, struct device_node *dp) +static int uflash_devinit(struct platform_device *op, struct device_node *dp) { struct uflash_dev *up;