| Message ID | 20240220003433.3316148-1-javierm@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | sparc: Fix undefined reference to fb_is_primary_device | expand |
Am 20.02.24 um 01:34 schrieb Javier Martinez Canillas: > Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE > symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only > have fbcon/VT and DRM fbdev emulation, but without support for any legacy > fbdev driver. > > Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and > that leads to the following linking error in some sparc64 configurations: > > sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function `fbcon_fb_registered': >>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device' > Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE symbols") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/ > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de> > --- > > I don't have a sparc64 toolchain to test this patch, but I'm pretty sure > that this is the correct fix for the linking error reported by the robot. > > arch/sparc/video/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sparc/video/Makefile b/arch/sparc/video/Makefile > index 6baddbd58e4d..d4d83f1702c6 100644 > --- a/arch/sparc/video/Makefile > +++ b/arch/sparc/video/Makefile > @@ -1,3 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > > -obj-$(CONFIG_FB) += fbdev.o > +obj-$(CONFIG_FB_CORE) += fbdev.o
On Tue, Feb 20, 2024, at 01:34, Javier Martinez Canillas wrote: > Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE > symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only > have fbcon/VT and DRM fbdev emulation, but without support for any legacy > fbdev driver. > > Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and > that leads to the following linking error in some sparc64 configurations: > > sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function > `fbcon_fb_registered': >>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device' > > Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and > FB_CORE symbols") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/ > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> Acked-by; Arnd Bergmann <arnd@arndb.de>
Hi Am 20.02.24 um 01:34 schrieb Javier Martinez Canillas: > Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE > symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only > have fbcon/VT and DRM fbdev emulation, but without support for any legacy > fbdev driver. > > Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and > that leads to the following linking error in some sparc64 configurations: > > sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function `fbcon_fb_registered': >>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device' > Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE symbols") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/ > Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> > --- > > I don't have a sparc64 toolchain to test this patch, but I'm pretty sure > that this is the correct fix for the linking error reported by the robot. > > arch/sparc/video/Makefile | 2 +- I think you also have to fix arch/sparc/Makefile. Best regards Thomas > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/sparc/video/Makefile b/arch/sparc/video/Makefile > index 6baddbd58e4d..d4d83f1702c6 100644 > --- a/arch/sparc/video/Makefile > +++ b/arch/sparc/video/Makefile > @@ -1,3 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > > -obj-$(CONFIG_FB) += fbdev.o > +obj-$(CONFIG_FB_CORE) += fbdev.o
Thomas Zimmermann <tzimmermann@suse.de> writes: Hello Thomas, > Hi > > Am 20.02.24 um 01:34 schrieb Javier Martinez Canillas: >> Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE >> symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only >> have fbcon/VT and DRM fbdev emulation, but without support for any legacy >> fbdev driver. >> >> Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and >> that leads to the following linking error in some sparc64 configurations: >> >> sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function `fbcon_fb_registered': >>>> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device' >> Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE symbols") >> Reported-by: kernel test robot <lkp@intel.com> >> Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/ >> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> >> --- >> >> I don't have a sparc64 toolchain to test this patch, but I'm pretty sure >> that this is the correct fix for the linking error reported by the robot. >> >> arch/sparc/video/Makefile | 2 +- > > I think you also have to fix arch/sparc/Makefile. > Oh, you are right! Thanks for pointing that. > Best regards > Thomas >
diff --git a/arch/sparc/video/Makefile b/arch/sparc/video/Makefile index 6baddbd58e4d..d4d83f1702c6 100644 --- a/arch/sparc/video/Makefile +++ b/arch/sparc/video/Makefile @@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_FB) += fbdev.o +obj-$(CONFIG_FB_CORE) += fbdev.o
Commit 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE symbols") added a new FB_CORE Kconfig symbol, that can be enabled to only have fbcon/VT and DRM fbdev emulation, but without support for any legacy fbdev driver. Unfortunately, it missed to change a CONFIG_FB in arch/sparc/Makefile and that leads to the following linking error in some sparc64 configurations: sparc64-linux-ld: drivers/video/fbdev/core/fbcon.o: in function `fbcon_fb_registered': >> fbcon.c:(.text+0x4f60): undefined reference to `fb_is_primary_device' Fixes: 55bffc8170bb ("fbdev: Split frame buffer support in FB and FB_CORE symbols") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/r/202401290306.IV8rhJ02-lkp@intel.com/ Signed-off-by: Javier Martinez Canillas <javierm@redhat.com> --- I don't have a sparc64 toolchain to test this patch, but I'm pretty sure that this is the correct fix for the linking error reported by the robot. arch/sparc/video/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)