| Message ID | 20231203101418.1910661-1-masahiroy@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] sparc: vdso: clean up build artifacts in arch/sparc/vdso/ | expand |
Hi Masahiro. On Sun, Dec 03, 2023 at 07:14:16PM +0900, Masahiro Yamada wrote: > Currently, vdso-image-*.c, vdso*.so, vdso*.so.dbg are not cleaned > because 'make clean' does not include include/config/auto.conf, > resulting in $(vdso_img-y) being empty. > > Add the build artifacts to 'targets' unconditionally. > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> Nice small fix/clean-ups. This and the following two patches are: Acked-by: Sam Ravnborg <sam@ravnborg.org> > --- > > arch/sparc/vdso/Makefile | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile > index d08c3a0443f3..eb52d0666ffc 100644 > --- a/arch/sparc/vdso/Makefile > +++ b/arch/sparc/vdso/Makefile > @@ -24,11 +24,8 @@ targets += vdso.lds $(vobjs-y) > > # Build the vDSO image C files and link them in. > vdso_img_objs := $(vdso_img-y:%=vdso-image-%.o) > -vdso_img_cfiles := $(vdso_img-y:%=vdso-image-%.c) > -vdso_img_sodbg := $(vdso_img-y:%=vdso%.so.dbg) > obj-y += $(vdso_img_objs) > -targets += $(vdso_img_cfiles) > -targets += $(vdso_img_sodbg) $(vdso_img-y:%=vdso%.so) > +targets += $(foreach x, 32 64, vdso-image-$(x).c vdso$(x).so vdso$(x).so.dbg) > > CPPFLAGS_vdso.lds += -P -C > > -- > 2.40.1 >
On Mon, Dec 4, 2023 at 4:21 AM Sam Ravnborg <sam@ravnborg.org> wrote: > > Hi Masahiro. > > On Sun, Dec 03, 2023 at 07:14:16PM +0900, Masahiro Yamada wrote: > > Currently, vdso-image-*.c, vdso*.so, vdso*.so.dbg are not cleaned > > because 'make clean' does not include include/config/auto.conf, > > resulting in $(vdso_img-y) being empty. > > > > Add the build artifacts to 'targets' unconditionally. > > > > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > > Nice small fix/clean-ups. > > This and the following two patches are: > Acked-by: Sam Ravnborg <sam@ravnborg.org> > > > --- > > Series, applied to linux-kbuild.
diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile index d08c3a0443f3..eb52d0666ffc 100644 --- a/arch/sparc/vdso/Makefile +++ b/arch/sparc/vdso/Makefile @@ -24,11 +24,8 @@ targets += vdso.lds $(vobjs-y) # Build the vDSO image C files and link them in. vdso_img_objs := $(vdso_img-y:%=vdso-image-%.o) -vdso_img_cfiles := $(vdso_img-y:%=vdso-image-%.c) -vdso_img_sodbg := $(vdso_img-y:%=vdso%.so.dbg) obj-y += $(vdso_img_objs) -targets += $(vdso_img_cfiles) -targets += $(vdso_img_sodbg) $(vdso_img-y:%=vdso%.so) +targets += $(foreach x, 32 64, vdso-image-$(x).c vdso$(x).so vdso$(x).so.dbg) CPPFLAGS_vdso.lds += -P -C
Currently, vdso-image-*.c, vdso*.so, vdso*.so.dbg are not cleaned because 'make clean' does not include include/config/auto.conf, resulting in $(vdso_img-y) being empty. Add the build artifacts to 'targets' unconditionally. Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> --- arch/sparc/vdso/Makefile | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)