| Message ID | 20230526184139.4.Iccee2d1ea19114dafb6553a854ea4d8ab2a3f25b@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | watchdog: Cleanup / fixes after buddy series v5 reviews | expand |
On Fri 2023-05-26 18:41:34, Douglas Anderson wrote: > In the patch ("watchdog/hardlockup: add a "cpu" param to > watchdog_hardlockup_check()") we started using a cpumask to keep track > of which CPUs to backtrace. When setting up this cpumask, it's better > to use cpumask_copy() than to just copy the structure directly. Fix this. > > Suggested-by: Petr Mladek <pmladek@suse.com> > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Petr Mladek <pmladek@suse.com> Best Regards, Petr
diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 32dac8028753..85f4839b6faf 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -154,7 +154,9 @@ void watchdog_hardlockup_check(unsigned int cpu, struct pt_regs *regs) */ if (is_hardlockup(cpu)) { unsigned int this_cpu = smp_processor_id(); - struct cpumask backtrace_mask = *cpu_online_mask; + struct cpumask backtrace_mask; + + cpumask_copy(&backtrace_mask, cpu_online_mask); /* Only print hardlockups once. */ if (per_cpu(watchdog_hardlockup_warned, cpu))
In the patch ("watchdog/hardlockup: add a "cpu" param to watchdog_hardlockup_check()") we started using a cpumask to keep track of which CPUs to backtrace. When setting up this cpumask, it's better to use cpumask_copy() than to just copy the structure directly. Fix this. Suggested-by: Petr Mladek <pmladek@suse.com> Signed-off-by: Douglas Anderson <dianders@chromium.org> --- kernel/watchdog.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)