| Message ID | 20220607033306.688-1-linmq006@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] sparc: kernel: Fix reference leak in jbusmc_probe | expand |
diff --git a/arch/sparc/kernel/of_device_32.c b/arch/sparc/kernel/of_device_32.c index 4ebf51e6e78e..020b1c023d75 100644 --- a/arch/sparc/kernel/of_device_32.c +++ b/arch/sparc/kernel/of_device_32.c @@ -412,8 +412,10 @@ static int __init scan_of_devices(void) struct platform_device *parent; parent = scan_one_device(root, NULL); - if (!parent) + if (!parent) { + of_node_put(root); return 0; + } scan_tree(root->child, &parent->dev); return 0; diff --git a/arch/sparc/kernel/of_device_64.c b/arch/sparc/kernel/of_device_64.c index 5a9f86b1d4e7..f044b4c1975b 100644 --- a/arch/sparc/kernel/of_device_64.c +++ b/arch/sparc/kernel/of_device_64.c @@ -705,8 +705,10 @@ static int __init scan_of_devices(void) struct platform_device *parent; parent = scan_one_device(root, NULL); - if (!parent) + if (!parent) { + of_node_put(root); return 0; + } scan_tree(root->child, &parent->dev); return 0;
of_find_node_by_path() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: cf44bbc26cf1 ("[SPARC]: Beginnings of generic of_device framework.") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- arch/sparc/kernel/of_device_32.c | 4 +++- arch/sparc/kernel/of_device_64.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-)