| Message ID | 1410286110-24956-1-git-send-email-ricardo.ribalda@gmail.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Date: Tue, 9 Sep 2014 20:08:30 +0200 > diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h > index 897d172..4e1c5da 100644 > --- a/arch/sparc/include/uapi/asm/ioctls.h > +++ b/arch/sparc/include/uapi/asm/ioctls.h > @@ -24,6 +24,8 @@ > #define TIOCGPKT _IOR('T', 0x38, int) /* Get packet mode state */ > #define TIOCGPTLCK _IOR('T', 0x39, int) /* Get Pty lock state */ > #define TIOCGEXCL _IOR('T', 0x40, int) /* Get exclusive mode state */ > +#define TIOCGRS485 0x542E > +#define TIOCSRS485 0x542F Please follow the ioctl numbering scheme used by the particular architecture UAPI file you are editing. Since Sparc here is using incrementing _IO*() values, including the type for the object passed in/out of the ioctl, you should do similarly for TIOC{G,S}RS485. -- To unsubscribe from this list: send the line "unsubscribe sparclinux" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello David Thanks for you comments, I thought it was a good idea that the same ioctl had the same value on all the arch, sorry to make a mess on your file :) I have just resend a v2 of the patch. Regards! On Tue, Sep 9, 2014 at 8:26 PM, David Miller <davem@davemloft.net> wrote: > From: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > Date: Tue, 9 Sep 2014 20:08:30 +0200 > >> diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h >> index 897d172..4e1c5da 100644 >> --- a/arch/sparc/include/uapi/asm/ioctls.h >> +++ b/arch/sparc/include/uapi/asm/ioctls.h >> @@ -24,6 +24,8 @@ >> #define TIOCGPKT _IOR('T', 0x38, int) /* Get packet mode state */ >> #define TIOCGPTLCK _IOR('T', 0x39, int) /* Get Pty lock state */ >> #define TIOCGEXCL _IOR('T', 0x40, int) /* Get exclusive mode state */ >> +#define TIOCGRS485 0x542E >> +#define TIOCSRS485 0x542F > > Please follow the ioctl numbering scheme used by the particular > architecture UAPI file you are editing. > > Since Sparc here is using incrementing _IO*() values, including the type > for the object passed in/out of the ioctl, you should do similarly for > TIOC{G,S}RS485.
diff --git a/arch/sparc/include/uapi/asm/ioctls.h b/arch/sparc/include/uapi/asm/ioctls.h index 897d172..4e1c5da 100644 --- a/arch/sparc/include/uapi/asm/ioctls.h +++ b/arch/sparc/include/uapi/asm/ioctls.h @@ -24,6 +24,8 @@ #define TIOCGPKT _IOR('T', 0x38, int) /* Get packet mode state */ #define TIOCGPTLCK _IOR('T', 0x39, int) /* Get Pty lock state */ #define TIOCGEXCL _IOR('T', 0x40, int) /* Get exclusive mode state */ +#define TIOCGRS485 0x542E +#define TIOCSRS485 0x542F /* Note that all the ioctls that are not available in Linux have a * double underscore on the front to: a) avoid some programs to
Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 (serial/8250: Add support for RS485 IOCTLs), adds support for RS485 ioctls for 825_core on all the archs. Unfortunaltely the definition of TIOCSRS485 and TIOCGRS485 was missing on the ioctls.h file Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> --- arch/sparc/include/uapi/asm/ioctls.h | 2 ++ 1 file changed, 2 insertions(+)