| Message ID | cover.1709591118.git.u.kleine-koenig@pengutronix.de |
|---|---|
| Headers | show |
| Series | sbus: Convert to platform remove callback returning void | expand |
On 2024-03-04 23:30, Uwe Kleine-König wrote: > Hello, > > this series converts all platform drivers below drivers/sbus/platform to > struct platform_driver::remove_new(). See commit 5c5a7680e67b > ("platform: Provide a remove callback that returns no value") for an > extended explanation and the eventual goal. > > The first commit is a build fix. The remaining patches implement that > actual conversion. All conversations are trivial, because their > .remove() callbacks returned zero unconditionally. > > Apart from patch #2 building on top of #1, there are no > interdependencies between these patches, so they could be picked up > individually. But I'd hope that they get picked up all together by > Andreas (or Dave?). > > Best regards > Uwe > > Uwe Kleine-König (6): > sbus: Add prototype for bbc_envctrl_init and bbc_envctrl_cleanup to > header > sbus: bbc_i2c: Convert to platform remove callback returning void > sbus: display7seg: Convert to platform remove callback returning void > sbus: envctrl: Convert to platform remove callback returning void > sbus: flash: Convert to platform remove callback returning void > sbus: uctrl: Convert to platform remove callback returning void > > drivers/sbus/char/bbc_i2c.c | 9 ++------- > drivers/sbus/char/bbc_i2c.h | 3 +++ > drivers/sbus/char/display7seg.c | 6 ++---- > drivers/sbus/char/envctrl.c | 6 ++---- > drivers/sbus/char/flash.c | 6 ++---- > drivers/sbus/char/uctrl.c | 5 ++--- > 6 files changed, 13 insertions(+), 22 deletions(-) > > base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89 For the whole series, Reviewed-by: Andreas Larsson <andreas@gaisler.com> Picking this up to my for-next. Thanks, Andreas
Hello, this series converts all platform drivers below drivers/sbus/platform to struct platform_driver::remove_new(). See commit 5c5a7680e67b ("platform: Provide a remove callback that returns no value") for an extended explanation and the eventual goal. The first commit is a build fix. The remaining patches implement that actual conversion. All conversations are trivial, because their .remove() callbacks returned zero unconditionally. Apart from patch #2 building on top of #1, there are no interdependencies between these patches, so they could be picked up individually. But I'd hope that they get picked up all together by Andreas (or Dave?). Best regards Uwe Uwe Kleine-König (6): sbus: Add prototype for bbc_envctrl_init and bbc_envctrl_cleanup to header sbus: bbc_i2c: Convert to platform remove callback returning void sbus: display7seg: Convert to platform remove callback returning void sbus: envctrl: Convert to platform remove callback returning void sbus: flash: Convert to platform remove callback returning void sbus: uctrl: Convert to platform remove callback returning void drivers/sbus/char/bbc_i2c.c | 9 ++------- drivers/sbus/char/bbc_i2c.h | 3 +++ drivers/sbus/char/display7seg.c | 6 ++---- drivers/sbus/char/envctrl.c | 6 ++---- drivers/sbus/char/flash.c | 6 ++---- drivers/sbus/char/uctrl.c | 5 ++--- 6 files changed, 13 insertions(+), 22 deletions(-) base-commit: 67908bf6954b7635d33760ff6dfc189fc26ccc89