From patchwork Fri Jul 20 11:57:26 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Russell Currey X-Patchwork-Id: 946848 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41X8Xt49wyz9s7c for ; Fri, 20 Jul 2018 21:58:22 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=russell.cc Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="NDuvfCYB"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41X8Xt2bkdzDqDX for ; Fri, 20 Jul 2018 21:58:22 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=russell.cc Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="NDuvfCYB"; dkim-atps=neutral X-Original-To: snowpatch@lists.ozlabs.org Delivered-To: snowpatch@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=russell.cc (client-ip=64.147.123.21; helo=wout5-smtp.messagingengine.com; envelope-from=ruscur@russell.cc; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=russell.cc Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=messagingengine.com header.i=@messagingengine.com header.b="NDuvfCYB"; dkim-atps=neutral Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41X8Xc4TsfzDqCG for ; Fri, 20 Jul 2018 21:58:08 +1000 (AEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 0DDAB3D1; Fri, 20 Jul 2018 07:58:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 20 Jul 2018 07:58:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=K2ztpu12jYAsFAzM9SVb58aMnkCFJnnDAkQZbJpRcBs=; b=NDuvfCYB X1P8qPBLyM4eC36XKtklk7b9xw9fBsYDAbNRWCIqXiWh7q3t6+VP4OnbUbTs5xet KzV2uhpiuUT+2pmU3FpvOCNC6eJ8ZYKBhZz76fB6VNyt3BZvSd4wJFe3fANsSjng jVvQFQkd8EWejf1YO5hi4ca8ua4w42bnH4RwduqDYoZz4RIrV4d3ToirHMMG3VC6 ysQw7+heCOHGupDMvg6C1rJNv/2QSLb017cSZct5Ug8fSNT7MXrgANXwgR31eRo3 v/63C+8KyTe6KYTFe5E6Soa5D3KcOHPHQhjJT6fZyOHykmLMpjo3wm4YF1fGgbkI 0bZDLAVan9F0jA== X-ME-Proxy: X-ME-Sender: Received: from snap.ozlabs.ibm.com (unknown [122.99.82.10]) by mail.messagingengine.com (Postfix) with ESMTPA id 253E510269; Fri, 20 Jul 2018 07:58:01 -0400 (EDT) From: Russell Currey To: snowpatch@lists.ozlabs.org, andrew.donnellan@au1.ibm.com Date: Fri, 20 Jul 2018 21:57:26 +1000 Message-Id: <20180720115728.19312-6-ruscur@russell.cc> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180720115728.19312-1-ruscur@russell.cc> References: <20180720115728.19312-1-ruscur@russell.cc> Subject: [snowpatch] [PATCH 6/8] Clean up an unnecessary clone X-BeenThere: snowpatch@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Continuous Integration for patch-based workflows List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Russell Currey MIME-Version: 1.0 Errors-To: snowpatch-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "snowpatch" Signed-off-by: Russell Currey Reviewed-by: Andrew Donnellan --- src/main.rs | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/main.rs b/src/main.rs index 027ceae..5d34b36 100644 --- a/src/main.rs +++ b/src/main.rs @@ -251,22 +251,12 @@ fn test_patch( let settings = settings.clone(); let project = project.clone(); let client = client.clone(); - let settings_clone = settings.clone(); let test_all_branches = project.test_all_branches.unwrap_or(true); // We've set up a remote branch, time to kick off tests let test = thread::Builder::new() .name(tag.to_string()) - .spawn(move || { - run_tests( - &settings_clone, - client, - &project, - &tag, - &branch_name, - hefty_tests, - ) - }) + .spawn(move || run_tests(&settings, client, &project, &tag, &branch_name, hefty_tests)) .unwrap(); results.append(&mut test.join().unwrap());