diff mbox series

[5/8] Don't link to job console output, link to job instead

Message ID 20180720115728.19312-5-ruscur@russell.cc
State Accepted
Headers show
Series [1/8] Convert from hyper to reqwest | expand

Commit Message

Russell Currey July 20, 2018, 11:57 a.m. UTC 
This is useful for projects with multiple artifacts, the console
text isn't always the best choice and it's only a click away.

Signed-off-by: Russell Currey <ruscur@russell.cc>
---
 src/jenkins.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andrew Donnellan July 23, 2018, 1:06 a.m. UTC | #1 
On 20/07/18 21:57, Russell Currey wrote:
> This is useful for projects with multiple artifacts, the console
> text isn't always the best choice and it's only a click away.
> 
> Signed-off-by: Russell Currey <ruscur@russell.cc>

This seems sensible.

Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>

> ---
>   src/jenkins.rs | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/jenkins.rs b/src/jenkins.rs
> index 987fae9..b751f59 100644
> --- a/src/jenkins.rs
> +++ b/src/jenkins.rs
> @@ -184,7 +184,7 @@ impl JenkinsBackend {
>       pub fn get_results_url(&self, build_url: &str, job: &BTreeMap<String, String>) -> String {
>           match job.get("artifact") {
>               Some(artifact) => format!("{}/artifact/{}", build_url, artifact),
> -            None => format!("{}/consoleText/", build_url),
> +            None => format!("{}/", build_url),
>           }
>       }
>   
>
diff mbox series

Patch

diff --git a/src/jenkins.rs b/src/jenkins.rs
index 987fae9..b751f59 100644
--- a/src/jenkins.rs
+++ b/src/jenkins.rs
@@ -184,7 +184,7 @@  impl JenkinsBackend {
     pub fn get_results_url(&self, build_url: &str, job: &BTreeMap<String, String>) -> String {
         match job.get("artifact") {
             Some(artifact) => format!("{}/artifact/{}", build_url, artifact),
-            None => format!("{}/consoleText/", build_url),
+            None => format!("{}/", build_url),
         }
     }