From patchwork Tue Nov 22 03:19:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Donnellan X-Patchwork-Id: 697535 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tN9gX10Pxz9s3s for ; Tue, 22 Nov 2016 14:19:36 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tN9gW4wblzDvZs for ; Tue, 22 Nov 2016 14:19:35 +1100 (AEDT) X-Original-To: snowpatch@lists.ozlabs.org Delivered-To: snowpatch@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tN9gT4LqtzDvYM for ; Tue, 22 Nov 2016 14:19:32 +1100 (AEDT) Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uAM3IghP035166 for ; Mon, 21 Nov 2016 22:19:29 -0500 Received: from e23smtp03.au.ibm.com (e23smtp03.au.ibm.com [202.81.31.145]) by mx0b-001b2d01.pphosted.com with ESMTP id 26v76gypny-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 21 Nov 2016 22:19:27 -0500 Received: from localhost by e23smtp03.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 22 Nov 2016 13:19:11 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp03.au.ibm.com (202.81.31.209) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 22 Nov 2016 13:19:09 +1000 Received: from d23relay06.au.ibm.com (d23relay06.au.ibm.com [9.185.63.219]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 7CFDD2CE8054 for ; Tue, 22 Nov 2016 14:19:08 +1100 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay06.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id uAM3J8lB52101178 for ; Tue, 22 Nov 2016 14:19:08 +1100 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id uAM3J8cN009656 for ; Tue, 22 Nov 2016 14:19:08 +1100 Received: from ozlabs.au.ibm.com (ozlabs.au.ibm.com [9.192.253.14]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id uAM3J8iF009653; Tue, 22 Nov 2016 14:19:08 +1100 Received: from ajd.ozlabs.ibm.com. (haven.au.ibm.com [9.192.254.114]) (using TLSv1.2 with cipher AES128-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.au.ibm.com (Postfix) with ESMTPSA id 05458A01BF; Tue, 22 Nov 2016 14:19:08 +1100 (AEDT) From: Andrew Donnellan To: snowpatch@lists.ozlabs.org Date: Tue, 22 Nov 2016 14:19:01 +1100 X-Mailer: git-send-email 2.10.2 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16112203-0008-0000-0000-000000E62275 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16112203-0009-0000-0000-0000088C8926 Message-Id: <20161122031901.9312-1-andrew.donnellan@au1.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-11-22_01:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609300000 definitions=main-1611220058 Subject: [snowpatch] [PATCH] jenkins: retry when Jenkins doesn't give us a build URL X-BeenThere: snowpatch@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Continuous Integration for patch-based workflows List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: snowpatch-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "snowpatch" From: Russell Currey Sometimes when we try to get the build URL, Jenkins isn't ready yet and responds without details of the "executable". Rather than panic, retry every 5 seconds until we get something we can use back. Like other loops in the code, we need to have a timeout eventually. Signed-off-by: Russell Currey [ajd: rework the logic and commit message] Signed-off-by: Andrew Donnellan --- src/jenkins.rs | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/src/jenkins.rs b/src/jenkins.rs index 0a0a699..6b92a85 100644 --- a/src/jenkins.rs +++ b/src/jenkins.rs @@ -114,9 +114,19 @@ impl JenkinsBackend { } pub fn get_build_url(&self, build_queue_entry: &str) -> Option { - match self.get_api_json_object(build_queue_entry).get("executable") { - Some(exec) => Some(exec.as_object().unwrap().get("url").unwrap().as_string().unwrap().to_string()), - None => None + loop { + let entry = self.get_api_json_object(build_queue_entry); + match entry.get("executable") { + Some(exec) => return Some(exec + .as_object() // Option + .unwrap() // BTreeMap + .get("url") // Option<&str> ? + .unwrap() // &str ? + .as_string() + .unwrap() + .to_string()), + None => sleep(Duration::from_millis(JENKINS_POLLING_INTERVAL)), + } } }