From patchwork Mon May 8 04:37:31 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 759512 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wLqW21Xr7z9s7g for ; Mon, 8 May 2017 14:38:06 +1000 (AEST) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3wLqW20nxNzDqJC for ; Mon, 8 May 2017 14:38:06 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wLqVn2VllzDqFW for ; Mon, 8 May 2017 14:37:53 +1000 (AEST) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v484XTtE018153 for ; Mon, 8 May 2017 00:37:42 -0400 Received: from e13.ny.us.ibm.com (e13.ny.us.ibm.com [129.33.205.203]) by mx0b-001b2d01.pphosted.com with ESMTP id 2aahm80ha0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 08 May 2017 00:37:41 -0400 Received: from localhost by e13.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 8 May 2017 00:37:40 -0400 Received: from b01cxnp23034.gho.pok.ibm.com (9.57.198.29) by e13.ny.us.ibm.com (146.89.104.200) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 8 May 2017 00:37:37 -0400 Received: from b01ledav005.gho.pok.ibm.com (b01ledav005.gho.pok.ibm.com [9.57.199.110]) by b01cxnp23034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v484bbmY45285414; Mon, 8 May 2017 04:37:37 GMT Received: from b01ledav005.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D597AE034; Mon, 8 May 2017 00:37:25 -0400 (EDT) Received: from birb.localdomain (unknown [9.83.0.169]) by b01ledav005.gho.pok.ibm.com (Postfix) with SMTP id 37341AE03B; Mon, 8 May 2017 00:37:23 -0400 (EDT) Received: by birb.localdomain (Postfix, from userid 1000) id 36D4A229EA8D; Mon, 8 May 2017 14:37:31 +1000 (AEST) From: Stewart Smith To: Benjamin Herrenschmidt , Michael Neuling , "Oliver O'Halloran" , skiboot@lists.ozlabs.org In-Reply-To: <1494000079.25766.400.camel@kernel.crashing.org> References: <20170504054704.31757-1-oohall@gmail.com> <1493964221.4280.19.camel@neuling.org> <1494000079.25766.400.camel@kernel.crashing.org> User-Agent: Notmuch/0.21+24~gbceb651 (http://notmuchmail.org) Emacs/25.2.1 (x86_64-redhat-linux-gnu) Date: Mon, 08 May 2017 14:37:31 +1000 MIME-Version: 1.0 X-TM-AS-GCONF: 00 x-cbid: 17050804-0008-0000-0000-0000021413A7 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007033; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000209; SDB=6.00857582; UDB=6.00424808; IPR=6.00637010; BA=6.00005329; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015352; XFM=3.00000014; UTC=2017-05-08 04:37:39 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17050804-0009-0000-0000-0000352E83A5 Message-Id: <878tm8neus.fsf@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-05-08_02:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1705080024 Subject: Re: [Skiboot] [PATCH] head.S: store all of LR and CTR X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Benjamin Herrenschmidt writes: > On Fri, 2017-05-05 at 16:03 +1000, Michael Neuling wrote: >> > @@ -198,8 +198,8 @@ _exception: >> >       mflr    %r6 >> >       stw     %r3,STACK_CR(%r1) >> >       stw     %r4,STACK_XER(%r1) >> > -     stw     %r5,STACK_CTR(%r1) >> > -     stw     %r5,STACK_LR(%r1) >> > +     std     %r5,STACK_CTR(%r1) >> > +     std     %r5,STACK_LR(%r1) > > You meant %r6 ? Well, it appears that bug has always been there. I'll merge something like this: diff --git a/asm/head.S b/asm/head.S index b10fbb554657..a2dcb8cddc85 100644 --- a/asm/head.S +++ b/asm/head.S @@ -199,7 +199,7 @@ _exception: stw %r3,STACK_CR(%r1) stw %r4,STACK_XER(%r1) std %r5,STACK_CTR(%r1) - std %r5,STACK_LR(%r1) + std %r6,STACK_LR(%r1) mfspr %r3,SPR_SRR0 mfspr %r4,SPR_SRR1 mfspr %r5,SPR_HSRR0