diff mbox series

external: Avoid parallelized 'make check' issues

Message ID 20260826181722.185124-1-arbab@linux.ibm.com
State Accepted
Headers show
Series external: Avoid parallelized 'make check' issues | expand

Commit Message

Reza Arbab Aug. 26, 2026, 6:17 p.m. UTC 
The $(TOOL) Makefiles have multiple latent race conditions that can
break parallel builds. I've found them very difficult to reproduce
locally, but GitHub CI runners hit them frustratingly often.

For an example, see commit d6f297ff7 ("external/ffspart: Avoid makefile
race condition").

Until time can be spent to properly address the remaining bugs or just
completely refactor the Makefiles into something sane, I think the
safest thing to do for now is force these targets to build sequentially
and get rid of the sporadic failures.

Signed-off-by: Reza Arbab <arbab@linux.ibm.com>
---
 external/Makefile.check | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Reza Arbab Sept. 4, 2026, 2:07 p.m. UTC | #1 
On Wed, Aug 26, 2026 at 01:17:22PM -0500, Reza Arbab wrote:
>Until time can be spent to properly address the remaining bugs or just
>completely refactor the Makefiles into something sane, I think the
>safest thing to do for now is force these targets to build sequentially
>and get rid of the sporadic failures.

Applied to master.
diff mbox series

Patch

diff --git a/external/Makefile.check b/external/Makefile.check
index d3d04c7ff..3a75bab1c 100644
--- a/external/Makefile.check
+++ b/external/Makefile.check
@@ -21,6 +21,10 @@  $(CHECK_TOOL):
 	$(call QTEST, RUN-TEST , make CC=$(HOSTCC) CROSS='' CROSS_COMPILE='' \
 		-C external/$(patsubst check-%,%,$@) check, $@)
 
+# Prevent parallel build of $(CHECK_TOOL) targets
+check-gard: check-pflash
+check-pflash: check-ffspart
+
 clean: $(TOOL_TEST_CLEAN)
 
 .PHONY: $(TOOL_COVERAGE)