| Message ID | 20230912205540.171611-1-arbab@linux.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | opal-ci: Use the Fedora container registry | expand |
Hi Reza, On Tue, 12 Sep 2023 15:55:40 -0500 Reza Arbab <arbab@linux.ibm.com> wrote: > The Fedora images in the Docker hub container registry are updated less > frequently and lag the ones from Fedora's offical repo. > > In my experience, this often leads to periods where our CI testing is > broken on rawhide due to some short-lived issue that is already fixed in > current images. > > So, change our Dockerfiles to pull specifically from the upstream > registry.fedoraproject.org instead. AFAIK there are some changes planned or on-going with the Fedora container registry, I will check the details and come back. Dan
On Tue, 12 Sep 2023 23:12:40 +0200 Dan Horák <dan@danny.cz> wrote: > Hi Reza, > > On Tue, 12 Sep 2023 15:55:40 -0500 > Reza Arbab <arbab@linux.ibm.com> wrote: > > > The Fedora images in the Docker hub container registry are updated less > > frequently and lag the ones from Fedora's offical repo. > > > > In my experience, this often leads to periods where our CI testing is > > broken on rawhide due to some short-lived issue that is already fixed in > > current images. > > > > So, change our Dockerfiles to pull specifically from the upstream > > registry.fedoraproject.org instead. > > AFAIK there are some changes planned or on-going with the Fedora > container registry, I will check the details and come back. so my memory was right and the details are in https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org/message/653M4FPQN22UMBVLQZW7GKR35USSSRV6/ I believe it's OK to download images from registry.fp.o, but it will go away eventually. Dan
On Tue, 12 Sep 2023 15:55:40 -0500 Reza Arbab <arbab@linux.ibm.com> wrote: > The Fedora images in the Docker hub container registry are updated less > frequently and lag the ones from Fedora's offical repo. > > In my experience, this often leads to periods where our CI testing is > broken on rawhide due to some short-lived issue that is already fixed in > current images. > > So, change our Dockerfiles to pull specifically from the upstream > registry.fedoraproject.org instead. > > Signed-off-by: Reza Arbab <arbab@linux.ibm.com> LGTM Reviewed-by: Dan Horák <dan@danny.cz> Dan > --- > opal-ci/Dockerfile-fedora-rawhide | 2 +- > opal-ci/Dockerfile-fedora37 | 2 +- > opal-ci/Dockerfile-fedora38 | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/opal-ci/Dockerfile-fedora-rawhide b/opal-ci/Dockerfile-fedora-rawhide > index 500b8044d824..b97ec50e38c4 100644 > --- a/opal-ci/Dockerfile-fedora-rawhide > +++ b/opal-ci/Dockerfile-fedora-rawhide > @@ -1,4 +1,4 @@ > -FROM fedora:rawhide > +FROM registry.fedoraproject.org/fedora:rawhide > RUN dnf -y update > RUN dnf -y install --allowerasing wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel gcc-powerpc64-linux-gnu mbedtls-devel which qemu-system-ppc > # for building documentation and the coverage report > diff --git a/opal-ci/Dockerfile-fedora37 b/opal-ci/Dockerfile-fedora37 > index 7ad3951fa92a..ce6081349977 100644 > --- a/opal-ci/Dockerfile-fedora37 > +++ b/opal-ci/Dockerfile-fedora37 > @@ -1,4 +1,4 @@ > -FROM fedora:37 > +FROM registry.fedoraproject.org/fedora:37 > RUN dnf -y update > RUN dnf -y install --allowerasing wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel gcc-powerpc64-linux-gnu mbedtls-devel which qemu-system-ppc > # for building documentation and the coverage report > diff --git a/opal-ci/Dockerfile-fedora38 b/opal-ci/Dockerfile-fedora38 > index 8638dd652357..5266f02b5358 100644 > --- a/opal-ci/Dockerfile-fedora38 > +++ b/opal-ci/Dockerfile-fedora38 > @@ -1,4 +1,4 @@ > -FROM fedora:38 > +FROM registry.fedoraproject.org/fedora:38 > RUN dnf -y update > RUN dnf -y install --allowerasing wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel gcc-powerpc64-linux-gnu mbedtls-devel which qemu-system-ppc > # for building documentation and the coverage report > -- > 2.39.3 > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
On Wed, Sep 13, 2023 at 04:52:46PM +0200, Dan Horák wrote: >On Tue, 12 Sep 2023 23:12:40 +0200 Dan Horák <dan@danny.cz> wrote: >> AFAIK there are some changes planned or on-going with the Fedora >> container registry, I will check the details and come back. > >so my memory was right and the details are in >https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org/message/653M4FPQN22UMBVLQZW7GKR35USSSRV6/ Good to know! Thank you for bringing this up. >I believe it's OK to download images from registry.fp.o, but it will go >away eventually. We can always change again should the location move. I'm mostly just interested in relieving the immediate frustration with Docker hub.
On 14/09/23 02:06, Reza Arbab wrote: > On Wed, Sep 13, 2023 at 04:52:46PM +0200, Dan Horák wrote: >> On Tue, 12 Sep 2023 23:12:40 +0200 Dan Horák <dan@danny.cz> wrote: >>> AFAIK there are some changes planned or on-going with the Fedora >>> container registry, I will check the details and come back. >> >> so my memory was right and the details are in >> https://lists.fedoraproject.org/archives/list/infrastructure@lists.fedoraproject.org/message/653M4FPQN22UMBVLQZW7GKR35USSSRV6/ >> > > Good to know! Thank you for bringing this up. > >> I believe it's OK to download images from registry.fp.o, but it will go >> away eventually. > > We can always change again should the location move. I'm mostly just > interested in relieving the immediate frustration with Docker hub. > I think this make sense. This patch looking good to me. I also tested github action working fine with this patch. Reviewed-by: Abhishek Singh Tomar <abhishek@linux.ibm.com>
On Tue, Sep 12, 2023 at 03:55:40PM -0500, Reza Arbab wrote: >The Fedora images in the Docker hub container registry are updated less >frequently and lag the ones from Fedora's offical repo. > >In my experience, this often leads to periods where our CI testing is >broken on rawhide due to some short-lived issue that is already fixed in >current images. > >So, change our Dockerfiles to pull specifically from the upstream >registry.fedoraproject.org instead. Applied to master.
diff --git a/opal-ci/Dockerfile-fedora-rawhide b/opal-ci/Dockerfile-fedora-rawhide index 500b8044d824..b97ec50e38c4 100644 --- a/opal-ci/Dockerfile-fedora-rawhide +++ b/opal-ci/Dockerfile-fedora-rawhide @@ -1,4 +1,4 @@ -FROM fedora:rawhide +FROM registry.fedoraproject.org/fedora:rawhide RUN dnf -y update RUN dnf -y install --allowerasing wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel gcc-powerpc64-linux-gnu mbedtls-devel which qemu-system-ppc # for building documentation and the coverage report diff --git a/opal-ci/Dockerfile-fedora37 b/opal-ci/Dockerfile-fedora37 index 7ad3951fa92a..ce6081349977 100644 --- a/opal-ci/Dockerfile-fedora37 +++ b/opal-ci/Dockerfile-fedora37 @@ -1,4 +1,4 @@ -FROM fedora:37 +FROM registry.fedoraproject.org/fedora:37 RUN dnf -y update RUN dnf -y install --allowerasing wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel gcc-powerpc64-linux-gnu mbedtls-devel which qemu-system-ppc # for building documentation and the coverage report diff --git a/opal-ci/Dockerfile-fedora38 b/opal-ci/Dockerfile-fedora38 index 8638dd652357..5266f02b5358 100644 --- a/opal-ci/Dockerfile-fedora38 +++ b/opal-ci/Dockerfile-fedora38 @@ -1,4 +1,4 @@ -FROM fedora:38 +FROM registry.fedoraproject.org/fedora:38 RUN dnf -y update RUN dnf -y install --allowerasing wget curl xterm gcc git xz make diffutils findutils expect valgrind valgrind-devel ccache dtc openssl openssl-devel gcc-powerpc64-linux-gnu mbedtls-devel which qemu-system-ppc # for building documentation and the coverage report
The Fedora images in the Docker hub container registry are updated less frequently and lag the ones from Fedora's offical repo. In my experience, this often leads to periods where our CI testing is broken on rawhide due to some short-lived issue that is already fixed in current images. So, change our Dockerfiles to pull specifically from the upstream registry.fedoraproject.org instead. Signed-off-by: Reza Arbab <arbab@linux.ibm.com> --- opal-ci/Dockerfile-fedora-rawhide | 2 +- opal-ci/Dockerfile-fedora37 | 2 +- opal-ci/Dockerfile-fedora38 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)