From patchwork Mon Jul 10 09:43:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Vaibhav Jain X-Patchwork-Id: 1805630 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=112.213.38.117; helo=lists.ozlabs.org; envelope-from=skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=tp7iyKOK; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Qzzb84WtKz20XS for ; Mon, 10 Jul 2023 19:43:32 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=tp7iyKOK; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4Qzzb70FvRz30fD for ; Mon, 10 Jul 2023 19:43:31 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=tp7iyKOK; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=vaibhav@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Qzzb32Wszz306p for ; Mon, 10 Jul 2023 19:43:27 +1000 (AEST) Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36A9HmLp024651 for ; Mon, 10 Jul 2023 09:43:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-type : content-transfer-encoding; s=pp1; bh=GwI88UaujXjwUrxz33JNpIHQPP3HoXdslrM6bFWis4k=; b=tp7iyKOKymwtLw6VY1CSQZVPkBxwMhxvmQ0cmxKAi0qMD7i1nKQy5z5MxDRh64FUCfbn rLe7tsVT4mNp52PkLD7HRdp//p/l7V3NCP2pDm4TitdccICiAeSl0Y3IKn+W2dm+Xi0a vQ7UfhTsx0k47lo2eC5TjdZfiyXqEWbx1J0CBkeXhNZ31OUJzx/nhTVLtDiNNGtatr87 5SMPxGoURTBx1FkeGBWJh1rW5/amQl3Jr7Y8HGmwJcQ9TOvVkq1g6K8Ya6QSAwzevpuf K8VvpbAwJxAl8OeqirmnpmBJw8Rc3Kh6xj13lh1ymYPLAWkBggELTNFMllJzEUxe5KLE tQ== Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rrf7r0mgn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Jul 2023 09:43:24 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36A3phFH017553 for ; Mon, 10 Jul 2023 09:43:22 GMT Received: from smtprelay06.fra02v.mail.ibm.com ([9.218.2.230]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3rpye5957s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 10 Jul 2023 09:43:22 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay06.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36A9hIlr43778504 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Jul 2023 09:43:19 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E5DEA20040; Mon, 10 Jul 2023 09:43:18 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4614220043; Mon, 10 Jul 2023 09:43:17 +0000 (GMT) Received: from vajain21.in.ibm.com (unknown [9.43.1.180]) by smtpav01.fra02v.mail.ibm.com (Postfix) with SMTP; Mon, 10 Jul 2023 09:43:17 +0000 (GMT) Received: by vajain21.in.ibm.com (sSMTP sendmail emulation); Mon, 10 Jul 2023 15:13:16 +0530 From: Vaibhav Jain To: skiboot@lists.ozlabs.org Date: Mon, 10 Jul 2023 15:13:11 +0530 Message-ID: <20230710094312.1377015-1-vaibhav@linux.ibm.com> X-Mailer: git-send-email 2.41.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: MABqxAq3eDnIT840TX6sOxmCQ42ZaN2I X-Proofpoint-ORIG-GUID: MABqxAq3eDnIT840TX6sOxmCQ42ZaN2I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-10_08,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0 bulkscore=0 adultscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=935 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307100086 Subject: [Skiboot] [PATCH] pau: Fix a build error with GCC 13.1.1 X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Compiling hmi.c with GCC 13.1.1 results in following error core/hmi.c:860:25: error: ‘pau’ may be used uninitialized [-Werror=maybe-uninitialized] 860 | pau_opencapi_dump_scoms(pau); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fix this by initializing variable 'pau' with NULL when defined in npu_fir_errors(). Variable 'pau' is only assigned/referenced in switch-case blocks when phb_type == phb_type_pau_opencapi. Hence this patch shouldn't introduce any behavioral changes. Signed-off-by: Vaibhav Jain --- core/hmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/hmi.c b/core/hmi.c index ce5abd7d6..dcb43afe0 100644 --- a/core/hmi.c +++ b/core/hmi.c @@ -774,7 +774,7 @@ static bool npu_fir_errors(struct phb *phb, int flat_chip_id, struct npu *npu; struct npu2 *npu2 = NULL; struct npu2_dev *dev; - struct pau *pau; + struct pau *pau = NULL; fir_regs = (phb->phb_type == phb_type_pcie_v3) ? 1 : 3;