From patchwork Fri Apr 8 15:31:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicholas Piggin X-Patchwork-Id: 1614962 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: bilbo.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=nf0Tzbn3; dkim-atps=neutral Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org (client-ip=2404:9400:2:0:216:3eff:fee1:b9f1; helo=lists.ozlabs.org; envelope-from=skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org; receiver=) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2404:9400:2:0:216:3eff:fee1:b9f1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by bilbo.ozlabs.org (Postfix) with ESMTPS id 4KZj0g0YGtz9sFq for ; Sat, 9 Apr 2022 01:32:03 +1000 (AEST) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4KZj0f6HRnz3bbG for ; Sat, 9 Apr 2022 01:32:02 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=nf0Tzbn3; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::42c; helo=mail-pf1-x42c.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=nf0Tzbn3; dkim-atps=neutral Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4KZj0S0NhYz2yJ9 for ; Sat, 9 Apr 2022 01:31:51 +1000 (AEST) Received: by mail-pf1-x42c.google.com with SMTP id p25so1933626pfn.13 for ; Fri, 08 Apr 2022 08:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nI6M+GMjp0jTq9/yCRhfcYqeLcfwqd0q3ZYVq6Jmfjg=; b=nf0Tzbn3ZjhwQruuklyjOVv1j/2j8yhmLP1DKlEUhnEGJ58HeT7LzWtRO9qIoRQIj7 YOSQEtlEHtv0QuyQZqR0o8ILBCteF6MZ90WX3idb+aVpPsBldcQbwSm2EosP7KBmYQ1k wLlaUfmjOf0jzsKyJAFamWVSS6dW+9pbqqfn/wLTl8eaYQ2MhKmZUV4uZDFOLkmX2NBE Fwfp8lSls/zDPUO8ItqmiIuidJ+n2EZ7mcgXoa/xjLj+jQwGiuSZ9mTf4ghqdNJ6ODFw gPZFqKq0W0etzXjeOIWmKOk2QmeGqnrlG/PljjU167IKHFW9wn/sc4Osy/DviPPGPLb4 Eryw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nI6M+GMjp0jTq9/yCRhfcYqeLcfwqd0q3ZYVq6Jmfjg=; b=RLyOdAFcBTALfDtIMB4y0dLlPJIpt/zgyFp7P+hxdysF6gRLMy87M631lC14kRmYNl 2r4JzfrVUTRJ1artbmG/LPXJX4V9eSsO/cYtPCMCEI7f1TgvCKutYHSXaZ/9IBm1tRuU zwViNq6MCduOGujDJr5HfdehBWyOapY3lOfyTNVqcLr14rvg1x4kIjLq8x3vb5Kp7bXH Oa71bFRN+Vqqf7Ed6sBNL4cRrEF4FtPXLgK4Vhy0MWNhKMoIpmnLrNjUioZDIsJwPbvw D4TByrm6eJ8DLWMVrbhCtMOW9AZoObIipnHj92V67qg061yN/ZrAwp90mUpoS4RGsQbs hpOA== X-Gm-Message-State: AOAM530ouzvEi1Y4Na5S56UpEDe7/Y+Ef0Bb3fAV2M1L8rfXx1duWUd8 TgMmdiKbTrNe7i8LDSrTATP9j8Kjn6M= X-Google-Smtp-Source: ABdhPJxhheG38X4CHm4uS02JxadAuJ1OxTwpNZBubfNqDJ2zz10Qdquqen3vgA56vyRiPzyr5oRZqQ== X-Received: by 2002:a63:3e4e:0:b0:398:997f:a442 with SMTP id l75-20020a633e4e000000b00398997fa442mr15767702pga.421.1649431909392; Fri, 08 Apr 2022 08:31:49 -0700 (PDT) Received: from bobo.ozlabs.ibm.com (220-235-208-104.tpgi.com.au. [220.235.208.104]) by smtp.gmail.com with ESMTPSA id y26-20020a056a00181a00b004fe3a6f02cesm14175172pfa.85.2022.04.08.08.31.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 08:31:49 -0700 (PDT) From: Nicholas Piggin To: skiboot@lists.ozlabs.org Date: Sat, 9 Apr 2022 01:31:34 +1000 Message-Id: <20220408153137.996621-2-npiggin@gmail.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20220408153137.996621-1-npiggin@gmail.com> References: <20220408153137.996621-1-npiggin@gmail.com> MIME-Version: 1.0 Subject: [Skiboot] [PATCH 1/4] core/hmi: fix endian conversion bug X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Fix an endian conversion bug in HMI checkstop reporting. Noticed by sparse. Signed-off-by: Nicholas Piggin Acked-by: Mahesh Salgaonkar --- core/hmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/hmi.c b/core/hmi.c index ce5abd7d6..46dc20dbb 100644 --- a/core/hmi.c +++ b/core/hmi.c @@ -915,7 +915,7 @@ static void find_npu_checkstop_reason(int flat_chip_id, hmi_evt->severity = OpalHMI_SEV_WARNING; hmi_evt->type = OpalHMI_ERROR_MALFUNC_ALERT; hmi_evt->u.xstop_error.xstop_type = CHECKSTOP_TYPE_NPU; - hmi_evt->u.xstop_error.xstop_reason = xstop_reason; + hmi_evt->u.xstop_error.xstop_reason = cpu_to_be32(xstop_reason); hmi_evt->u.xstop_error.u.chip_id = cpu_to_be32(flat_chip_id); /* Marking the event as recoverable so that we don't crash */