| Message ID | 20210625075518.82776-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [trivial] fsp: Fix sparse warning | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (9d52c580d3fabbea6b276b98f925ab0fceebb96c) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | success | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On 6/25/21 1:25 PM, Vasant Hegde wrote: > platforms/ibm-fsp/common.c:252:17: error: symbol 'fsp_heartbeat_time' redeclared with different type (different modifiers): > platforms/ibm-fsp/common.c:252:17: int extern [addressable] [pure] [signed] [toplevel] fsp_heartbeat_time( ... ) > platforms/ibm-fsp/common.c: note: in included file: > platforms/ibm-fsp/ibm-fsp.h:40:5: note: previously declared as: > platforms/ibm-fsp/ibm-fsp.h:40:5: int extern [addressable] [signed] [toplevel] fsp_heartbeat_time( ... ) > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- Merged to master as 7c4862e. -Vasant
diff --git a/platforms/ibm-fsp/ibm-fsp.h b/platforms/ibm-fsp/ibm-fsp.h index c21866912..bb191645c 100644 --- a/platforms/ibm-fsp/ibm-fsp.h +++ b/platforms/ibm-fsp/ibm-fsp.h @@ -37,7 +37,7 @@ void vpd_iohub_load(struct dt_node *hub_node); void vpd_preload(struct dt_node *hub_node); /* Platform heartbeat time */ -int fsp_heartbeat_time(void); +int __attrconst fsp_heartbeat_time(void); extern struct platform_psi fsp_platform_psi; extern struct platform_prd fsp_platform_prd;
platforms/ibm-fsp/common.c:252:17: error: symbol 'fsp_heartbeat_time' redeclared with different type (different modifiers): platforms/ibm-fsp/common.c:252:17: int extern [addressable] [pure] [signed] [toplevel] fsp_heartbeat_time( ... ) platforms/ibm-fsp/common.c: note: in included file: platforms/ibm-fsp/ibm-fsp.h:40:5: note: previously declared as: platforms/ibm-fsp/ibm-fsp.h:40:5: int extern [addressable] [signed] [toplevel] fsp_heartbeat_time( ... ) Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- platforms/ibm-fsp/ibm-fsp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)