| Message ID | 20190929074651.8787-6-npiggin@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | little endian skiboot | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (470ffb5f29d741c3bed600f7bb7bf0cbb270e05a) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | fail | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On Sun, 2019-09-29 at 17:46 +1000, Nicholas Piggin wrote: > Signed-off-by: Nicholas Piggin <npiggin@gmail.com> > --- > hdata/memory.c | 3 ++- > hdata/spira.c | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/hdata/memory.c b/hdata/memory.c > index 9af7ae71d..2a199ae83 100644 > --- a/hdata/memory.c > +++ b/hdata/memory.c > @@ -135,7 +135,8 @@ static bool add_address_range(struct dt_node *root, > "on Chip 0x%x mattr: 0x%x pattr: 0x%x status:0x%x\n", > (long long)be64_to_cpu(arange->start), > (long long)be64_to_cpu(arange->end), > - chip_id, arange->mirror_attr, mem_type, mem_status); > + chip_id, (int)be32_to_cpu(arange->mirror_attr), Is that int cast needed? > + mem_type, mem_status); > > /* reg contains start and length */ > reg[0] = cleanup_addr(be64_to_cpu(arange->start)); > diff --git a/hdata/spira.c b/hdata/spira.c > index b0e8b88d1..40524e87e 100644 > --- a/hdata/spira.c > +++ b/hdata/spira.c > @@ -1652,7 +1652,7 @@ static void add_npus(void) > static void fixup_spira(void) > { > #if !defined(TEST) > - spiras = (struct spiras *)CPU_TO_BE64(SPIRA_HEAP_BASE); > + spiras = (struct spiras *)SPIRA_HEAP_BASE; > #endif > > /* Validate SPIRA-S signature */
Oliver O'Halloran's on October 1, 2019 1:56 pm: > On Sun, 2019-09-29 at 17:46 +1000, Nicholas Piggin wrote: >> Signed-off-by: Nicholas Piggin <npiggin@gmail.com> >> --- >> hdata/memory.c | 3 ++- >> hdata/spira.c | 2 +- >> 2 files changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/hdata/memory.c b/hdata/memory.c >> index 9af7ae71d..2a199ae83 100644 >> --- a/hdata/memory.c >> +++ b/hdata/memory.c >> @@ -135,7 +135,8 @@ static bool add_address_range(struct dt_node *root, >> "on Chip 0x%x mattr: 0x%x pattr: 0x%x status:0x%x\n", >> (long long)be64_to_cpu(arange->start), >> (long long)be64_to_cpu(arange->end), > >> - chip_id, arange->mirror_attr, mem_type, mem_status); >> + chip_id, (int)be32_to_cpu(arange->mirror_attr), > > Is that int cast needed? Don't think so. Thanks, Nick
diff --git a/hdata/memory.c b/hdata/memory.c index 9af7ae71d..2a199ae83 100644 --- a/hdata/memory.c +++ b/hdata/memory.c @@ -135,7 +135,8 @@ static bool add_address_range(struct dt_node *root, "on Chip 0x%x mattr: 0x%x pattr: 0x%x status:0x%x\n", (long long)be64_to_cpu(arange->start), (long long)be64_to_cpu(arange->end), - chip_id, arange->mirror_attr, mem_type, mem_status); + chip_id, (int)be32_to_cpu(arange->mirror_attr), + mem_type, mem_status); /* reg contains start and length */ reg[0] = cleanup_addr(be64_to_cpu(arange->start)); diff --git a/hdata/spira.c b/hdata/spira.c index b0e8b88d1..40524e87e 100644 --- a/hdata/spira.c +++ b/hdata/spira.c @@ -1652,7 +1652,7 @@ static void add_npus(void) static void fixup_spira(void) { #if !defined(TEST) - spiras = (struct spiras *)CPU_TO_BE64(SPIRA_HEAP_BASE); + spiras = (struct spiras *)SPIRA_HEAP_BASE; #endif /* Validate SPIRA-S signature */
Signed-off-by: Nicholas Piggin <npiggin@gmail.com> --- hdata/memory.c | 3 ++- hdata/spira.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-)