| Message ID | 20190905030845.15540-5-oohall@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/5] xive, interrupts: Add a mask() source op | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | Successfully applied on branch master (7b12d5489fcfd73ef7ec0cb27eff7f8a5f13b238) |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot | fail | Test snowpatch/job/snowpatch-skiboot on branch master |
| snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco | success | Signed-off-by present |
On 05/09/2019 05:08, Oliver O'Halloran wrote: > If the platform hasn't defined an external IRQ handler then we should > leave it directed at the OS. The OS can mask it if it wants to. > > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> Reviewed-by: Cédric Le Goater <clg@kaod.org> Thanks, C. > --- > platforms/astbmc/common.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c > index 85043f3b91e7..1f8a3f82c358 100644 > --- a/platforms/astbmc/common.c > +++ b/platforms/astbmc/common.c > @@ -465,8 +465,9 @@ void astbmc_early_init(void) > /* Hostboot forgets to populate the PSI BAR */ > astbmc_fixup_psi_bar(); > > - /* Send external interrupts to me */ > - psi_set_external_irq_policy(EXTERNAL_IRQ_POLICY_SKIBOOT); > + /* Send external interrupts to me if the platform can handle them */ > + if (platform.external_irq) > + psi_set_external_irq_policy(EXTERNAL_IRQ_POLICY_SKIBOOT); > > if (ast_sio_init()) { > if (ast_io_init()) { >
diff --git a/platforms/astbmc/common.c b/platforms/astbmc/common.c index 85043f3b91e7..1f8a3f82c358 100644 --- a/platforms/astbmc/common.c +++ b/platforms/astbmc/common.c @@ -465,8 +465,9 @@ void astbmc_early_init(void) /* Hostboot forgets to populate the PSI BAR */ astbmc_fixup_psi_bar(); - /* Send external interrupts to me */ - psi_set_external_irq_policy(EXTERNAL_IRQ_POLICY_SKIBOOT); + /* Send external interrupts to me if the platform can handle them */ + if (platform.external_irq) + psi_set_external_irq_policy(EXTERNAL_IRQ_POLICY_SKIBOOT); if (ast_sio_init()) { if (ast_io_init()) {
If the platform hasn't defined an external IRQ handler then we should leave it directed at the OS. The OS can mask it if it wants to. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- platforms/astbmc/common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)