diff mbox series

[trivial,2/2] opal-prd: Fix memory leak in is-fsp-system check

Message ID 20190409115125.18149-2-hegdevasant@linux.vnet.ibm.com
State Accepted
Headers show
Series [trivial,1/2] opal-prd: Check malloc return value | expand

Checks

Context Check Description
snowpatch_ozlabs/apply_patch success Successfully applied on branch master (050d8165ab05b6d9cdf4bfee42d9776969c77029)
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot success Test snowpatch/job/snowpatch-skiboot on branch master
snowpatch_ozlabs/snowpatch_job_snowpatch-skiboot-dco success Signed-off-by present

Commit Message

Vasant Hegde April 9, 2019, 11:51 a.m. UTC
Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>
---
 external/opal-prd/opal-prd.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/external/opal-prd/opal-prd.c b/external/opal-prd/opal-prd.c
index 41d13ecf7..33ea5f5a8 100644
--- a/external/opal-prd/opal-prd.c
+++ b/external/opal-prd/opal-prd.c
@@ -255,6 +255,7 @@  static void pr_log_daemon_init(void)
 /* Check service processor type */
 static bool is_fsp_system(void)
 {
+	bool fsp_system = true;
 	char *path;
 	int rc;
 
@@ -264,7 +265,11 @@  static bool is_fsp_system(void)
 		return false;
 	}
 
-	return access(path, F_OK) ? false : true;
+	if (access(path, F_OK))
+		fsp_system = false;
+
+	free(path);
+	return fsp_system;
 }
 
 /**