From patchwork Fri Jun 29 06:32:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Neuling X-Patchwork-Id: 936626 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41H6KL5wzBz9s19 for ; Fri, 29 Jun 2018 16:33:10 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=neuling.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41H6KL3C5yzF1PT for ; Fri, 29 Jun 2018 16:33:10 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=neuling.org X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from ozlabs.org (bilbo.ozlabs.org [203.11.71.1]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41H6Jg0YpLzF1Nv for ; Fri, 29 Jun 2018 16:32:35 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=neuling.org Received: from localhost.localdomain (localhost [127.0.0.1]) by ozlabs.org (Postfix) with ESMTP id 41H6Jf4cm7z9s19; Fri, 29 Jun 2018 16:32:34 +1000 (AEST) Received: by localhost.localdomain (Postfix, from userid 1000) id 5F038EE78BD; Fri, 29 Jun 2018 16:32:34 +1000 (AEST) From: Michael Neuling To: stewart@linux.vnet.ibm.com Date: Fri, 29 Jun 2018 16:32:20 +1000 Message-Id: <20180629063221.30731-2-mikey@neuling.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180629063221.30731-1-mikey@neuling.org> References: <20180629063221.30731-1-mikey@neuling.org> Subject: [Skiboot] [PATCH 2/3] phb4: Move training trace logging to next state. X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: skiboot@lists.ozlabs.org, Michael Neuling MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" I'm going to defer training to this state soon, so move the tracing first. Signed-off-by: Michael Neuling --- hw/phb4.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/phb4.c b/hw/phb4.c index 755bfe2034..d9a729369b 100644 --- a/hw/phb4.c +++ b/hw/phb4.c @@ -2836,11 +2836,11 @@ static int64_t phb4_freset(struct pci_slot *slot) pci_slot_set_state(slot, PHB4_SLOT_FRESET_DEASSERT_DELAY); - phb4_training_trace(p); - /* Move on to link poll right away */ return pci_slot_set_sm_timeout(slot, 1); case PHB4_SLOT_FRESET_DEASSERT_DELAY: + phb4_training_trace(p); + pci_slot_set_state(slot, PHB4_SLOT_LINK_START); return slot->ops.poll_link(slot); default: