diff mbox series

SLW: Fix mambo boot to use stop states

Message ID 20180502164611.754d85b8@kryten
State Accepted
Headers show
Series SLW: Fix mambo boot to use stop states | expand

Commit Message

Anton Blanchard May 2, 2018, 6:46 a.m. UTC 
After commit 35c66b8ce5a2 ("SLW: Move MAMBO simulator checks to
slw_init"), mambo boot no longer calls add_cpu_idle_state_properties()
and as such we never enable stop states.

After adding the call back, we get more testing coverage as well
as faster mambo SMT boots.

Signed-off-by: Anton Blanchard <anton@samba.org>
--

Comments

Stewart Smith May 3, 2018, 4:34 a.m. UTC | #1 
Anton Blanchard <anton@ozlabs.org> writes:
> After commit 35c66b8ce5a2 ("SLW: Move MAMBO simulator checks to
> slw_init"), mambo boot no longer calls add_cpu_idle_state_properties()
> and as such we never enable stop states.
>
> After adding the call back, we get more testing coverage as well
> as faster mambo SMT boots.
>
> Signed-off-by: Anton Blanchard <anton@samba.org>
> --

Cheers, seemed to pass the mambo tests we have in travis, so merged to
master as of 3ef38a3895e682627bcdafdeec8796db3f9bdaf9
diff mbox series

Patch

diff --git a/hw/slw.c b/hw/slw.c
index 8e845300..bce7d427 100644
--- a/hw/slw.c
+++ b/hw/slw.c
@@ -1581,6 +1581,7 @@  void slw_init(void)
 
 	if (proc_chip_quirks & QUIRK_MAMBO_CALLOUTS) {
 		wakeup_engine_state = WAKEUP_ENGINE_NOT_PRESENT;
+		add_cpu_idle_state_properties();
 		return;
 	}
 	if (proc_gen == proc_gen_p8) {