diff mbox series

xive: fix missing unlock in error path

Message ID 20180427055944.16012-1-stewart@linux.ibm.com
State Accepted
Headers show
Series xive: fix missing unlock in error path | expand

Commit Message

Stewart Smith April 27, 2018, 5:59 a.m. UTC 
Found with sparse and some added lock annotations.

Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
---
 hw/xive.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stewart Smith April 30, 2018, 7:41 a.m. UTC | #1 
Stewart Smith <stewart@linux.ibm.com> writes:
> Found with sparse and some added lock annotations.
>
> Signed-off-by: Stewart Smith <stewart@linux.ibm.com>
> ---
>  hw/xive.c | 1 +
>  1 file changed, 1 insertion(+)

Merged to master as of 693a204364b0c6d00ae6daa1721fd5c03a4de74e,
added in a FIxes and cherry picked to 5.10.x as well.
diff mbox series

Patch

diff --git a/hw/xive.c b/hw/xive.c
index 3ce19971c4cd..a66f3ff414a0 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -4402,6 +4402,7 @@  static int64_t opal_xive_set_vp_info(uint64_t vp_id,
 				xive_dbg(x, "Attempt at enabling single escalate"
 					 " on xive rev %d failed\n",
 					 x->rev);
+				unlock(&x->lock);
 				return OPAL_PARAMETER;
 			}
 			rc = xive_setup_silent_gather(vp_id, true);