Message ID | 20171130053129.22642-4-oohall@gmail.com |
---|---|
State | Accepted |
Headers | show
Return-Path: <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3ynQyq4RKpz9s9Y for <incoming@patchwork.ozlabs.org>; Thu, 30 Nov 2017 16:32:35 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EjziCbRH"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3ynQyq3CS0zDsNJ for <incoming@patchwork.ozlabs.org>; Thu, 30 Nov 2017 16:32:35 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EjziCbRH"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:400e:c00::244; helo=mail-pf0-x244.google.com; envelope-from=oohall@gmail.com; receiver=<UNKNOWN>) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="EjziCbRH"; dkim-atps=neutral Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3ynQxy2Sc0zDrq7 for <skiboot@lists.ozlabs.org>; Thu, 30 Nov 2017 16:31:50 +1100 (AEDT) Received: by mail-pf0-x244.google.com with SMTP id j28so2651495pfk.8 for <skiboot@lists.ozlabs.org>; Wed, 29 Nov 2017 21:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vg8dpJZbKuBSZAJICAXl2LB5otEjta0vuQ3/1AXjWBU=; b=EjziCbRHlBFf/5aObxw1oePXoLH/QPEmAcmSNaEadpGSfnJ9CqYgeAPUaJMyALioVs JiK0K0C7JkeLua6iPyvhh0SKs2CyVOmKxq+VCaZJcfMhqcCpjkvZebvOa0xFb/EgitIx UYPGcCErV9MKgf/neJYZ4wgtkkEHAJ7CdSXzSuK2Gnjj6scykKweACe06rEizp6kH7wV hjIcE+mIchd6uEI8CeOKisG0OYnVmaSG2/y9nAYDxHJKk4TmeKkqE3sguAwT+PpA6MjH NtQmLD8Urq1GihB4FPAnWeGPQOo9FQL+B6cty5mHgMZVNV8EReYc0HRQQo9eLtf3fZWj /2ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vg8dpJZbKuBSZAJICAXl2LB5otEjta0vuQ3/1AXjWBU=; b=g27ayvbOk9ezRIVzVvT2zmHjc5+i+t7Xvd7l+F6fpMsCUhIYpLwdQ9yn1iwEqVDqdJ +QIpEHy4vK7/01psrfJ0U5uDAyPu9mzJvq/1YYy7YrgRKb6B3+4e9QwVTRTe3NGvvSvQ 8Apq2Rv/W4tJOfEmRPJloFvWpB7+TU3xQX/qi6RFa/dqa1oH9zpaz8aP8uzzTYY6De9g jnnM5vJ/2gU7P/rI0oWet5Iwdrrl4W6AvU2o6d+tatIDWXjXRQge0VRROwUBJC5KkfVp Sr5WBGBlqOtzjWa1OBrGvM4aHyphSvThmljA5pNMFit6dDkuM0H6WmncUOjxBRGSAr+S mNDQ== X-Gm-Message-State: AJaThX4InVE4InSc7zEytOuqX0y/4YAh10Drs55ow67rmW9AcNZfE8me ZSqJmap3vt+WIicfX4BJ4b2Xjw== X-Google-Smtp-Source: AGs4zMaOH3uWZ9ImSUQNLsY9ugAsoWRidetM7zripbTc/dCZ5PB1HjDi1Z4f/uOrINnDuTrK6am1WA== X-Received: by 10.101.73.74 with SMTP id q10mr1291997pgs.127.1512019907822; Wed, 29 Nov 2017 21:31:47 -0800 (PST) Received: from flat-canetoad.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id j79sm6209348pfe.129.2017.11.29.21.31.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Nov 2017 21:31:47 -0800 (PST) From: Oliver O'Halloran <oohall@gmail.com> To: skiboot@lists.ozlabs.org Date: Thu, 30 Nov 2017 16:31:25 +1100 Message-Id: <20171130053129.22642-4-oohall@gmail.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20171130053129.22642-1-oohall@gmail.com> References: <20171130053129.22642-1-oohall@gmail.com> Subject: [Skiboot] [PATCH 4/8] gard: Fix max instance count X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.24 Precedence: list List-Id: Mailing list for skiboot development <skiboot.lists.ozlabs.org> List-Unsubscribe: <https://lists.ozlabs.org/options/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=unsubscribe> List-Archive: <http://lists.ozlabs.org/pipermail/skiboot/> List-Post: <mailto:skiboot@lists.ozlabs.org> List-Help: <mailto:skiboot-request@lists.ozlabs.org?subject=help> List-Subscribe: <https://lists.ozlabs.org/listinfo/skiboot>, <mailto:skiboot-request@lists.ozlabs.org?subject=subscribe> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" <skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org> |
Series | [1/8] gard: Allow records with an ID of 0xffffffff | expand |
diff --git a/external/gard/gard.c b/external/gard/gard.c index 5a57415ab5a7..d7a0876bbf31 100644 --- a/external/gard/gard.c +++ b/external/gard/gard.c @@ -340,9 +340,9 @@ int parse_path(const char *str, struct entity_path *parsed) return -1; } - if (instance > 15 || instance < 0) { + if (instance > 255 || instance < 0) { fprintf(stderr, - "Instance %ld is invalid. Must be 0 to 15\n", + "Instance %ld is invalid. Must be 0 to 255\n", instance); return -1; }
There's an entire byte for the instance count rather than a nibble. Only barf if the instance number is beyond 255 rather than 16. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- external/gard/gard.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)