diff mbox series

phb4: Update link training documentation

Message ID 20170921072318.32481-1-mikey@neuling.org
State Accepted
Headers show
Series phb4: Update link training documentation | expand

Commit Message

Michael Neuling Sept. 21, 2017, 7:23 a.m. UTC 
We added degraded link retries in:
   3f936bae97 phb4: Retrain link if degraded
but forgot to update the documentation.

Signed-off-by: Michael Neuling <mikey@neuling.org>
---
 hw/phb4.c | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Stewart Smith Sept. 28, 2017, 4:45 a.m. UTC | #1 
Michael Neuling <mikey@neuling.org> writes:
> We added degraded link retries in:
>    3f936bae97 phb4: Retrain link if degraded
> but forgot to update the documentation.

but... but... not updating documentation is tradition!

Merged as of 1c3f583bb767b1af43478c682b665b224b69b38e
diff mbox series

Patch

diff --git a/hw/phb4.c b/hw/phb4.c
index 48ea4bd50c..aea67b1afd 100644
--- a/hw/phb4.c
+++ b/hw/phb4.c
@@ -82,6 +82,14 @@ 
  *   o Once we leave here, much harder to recover from errors
  *
  * Step 9:
+ * - Check for optimised link for directly attached devices:
+ *   o Wait for CRS (so we can read device config space)
+ *   o Check chip and device are in whitelist. if not, Goto Step 10
+ *   o If trained link speed is degraded, retry ->  Goto Step 2
+ *   o If trained link width is degraded, retry -> Goto Step 2
+ *   o If still degraded after 3 retries. Give up, Goto Step 10.
+ *
+ * Step 10:
  *  - PHB good, start probing config space.
  *    o core/pci.c: pci_reset_phb() -> pci_scan_phb()
  */