| Message ID | 20170613082149.10076-1-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Jun 13, 2017 at 01:51:49PM +0530, Vasant Hegde wrote: > Now that we are using fsp_in_rr() to detect FSP reset/reload, fsp_in_reset > become redundant. Lets remove this local variable. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> Acked-by: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: > Now that we are using fsp_in_rr() to detect FSP reset/reload, fsp_in_reset > become redundant. Lets remove this local variable. > > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > hw/fsp/fsp-rtc.c | 10 ---------- > 1 file changed, 10 deletions(-) Thanks, merged to: master a34369631e6d85c26966eb0b8d5e4c44bcf96c7c 5.4.x 9fd3916d3031a2edecf50878c494966e729c7b33
diff --git a/hw/fsp/fsp-rtc.c b/hw/fsp/fsp-rtc.c index 1de22e8..dbc2131 100644 --- a/hw/fsp/fsp-rtc.c +++ b/hw/fsp/fsp-rtc.c @@ -88,12 +88,6 @@ static enum { static bool rtc_tod_cache_dirty = false; -/* TODO We'd probably want to export and use this variable declared in fsp.c, - * instead of each component individually maintaining the state.. may be for - * later optimization - */ -static bool fsp_in_reset = false; - struct opal_tpo_data { uint64_t tpo_async_token; uint32_t *year_month_day; @@ -528,14 +522,10 @@ static bool fsp_rtc_msg_rr(u32 cmd_sub_mod, struct fsp_msg *msg) switch (cmd_sub_mod) { case FSP_RESET_START: - lock(&rtc_lock); - fsp_in_reset = true; - unlock(&rtc_lock); rc = true; break; case FSP_RELOAD_COMPLETE: lock(&rtc_lock); - fsp_in_reset = false; if (rtc_tod_cache_dirty) { rtc_flush_cached_tod(); rtc_tod_cache_dirty = false;
Now that we are using fsp_in_rr() to detect FSP reset/reload, fsp_in_reset become redundant. Lets remove this local variable. Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- hw/fsp/fsp-rtc.c | 10 ---------- 1 file changed, 10 deletions(-)