From patchwork Thu May 4 00:23:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Brown X-Patchwork-Id: 758284 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3wJG4K3RFLz9ryT for ; Thu, 4 May 2017 10:24:33 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YGf26BVP"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3wJG4K2PMjzDqH6 for ; Thu, 4 May 2017 10:24:33 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YGf26BVP"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3wJG496DDczDq9m for ; Thu, 4 May 2017 10:24:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="YGf26BVP"; dkim-atps=neutral Received: by mail-pf0-x241.google.com with SMTP id v14so643655pfd.3 for ; Wed, 03 May 2017 17:24:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=aNv3IrMO0p8qlPAwEF4nkKjm/RoKvt5fpFbFAlHoDJI=; b=YGf26BVPyh8ZAxqydkaNN2QV0NDIIs0UtQZENWN/Y7F9v0wmn8MXcdMwp1eBoHI/7x QRlCXSbp7dUhxNJVDLH4gXO+sk1dCYhU3evqXdVhNrvPLSYuV16ODe4kD+VcQQ2cB2KH EtBCrc5UxB1IbFqCMWBxKfvRMDTofdLN0AJw/rwfsJcwT5Jc3/DMMJCgVn91YM/OXzmb LvM61MjeLQ5ALPXINwxprMLoLER3Sbv9GsZTHPHMUoDS9wiqy7beuda+7enSs45Ma5TR ULlxS4lpaaMl5DCoWICELWbPXxM0t/hr0uHbJR6nXc5VpLCe3biunrh3RZjsWBeplFhs H5jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=aNv3IrMO0p8qlPAwEF4nkKjm/RoKvt5fpFbFAlHoDJI=; b=Bnt8/2iVI3BCudoD8fVaaz4k7TTpDp372iMN5KJAnjaGUtoTITfK9FQWd5o3go/suz RUluJwG1ucXfrZ8lO1pDyRU7mmNtGFIViewj/0bN1Y3mmeUywVVxEo5+khiWZtsHj186 JyaPl0ov/kd8RRtd6M606jxc40I5rHndEpueXY6P53Sb226CRPGIb5updpduldBPnpnw kl9CmExXJNDj2w6gVkqmDn50KIKeo/tJnERmLbh9VxaNBy3dsdXLcIrRZFxRv8yCX/h5 qWIHglrxM7ilW9Dxh6pre3a6cqTAyr7dTot6JzzETkdzrUN2EzZCORTm6hx2or8L6iy+ EszA== X-Gm-Message-State: AN3rC/533N66GSZ4GRLSuH9rZXvdddKx3/FfO3uS6tTdUQW4WHx6Rbwd 6xta3t1YhBPPpBuf X-Received: by 10.98.107.73 with SMTP id g70mr7894992pfc.22.1493857463412; Wed, 03 May 2017 17:24:23 -0700 (PDT) Received: from matt.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id b126sm472643pga.3.2017.05.03.17.24.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 May 2017 17:24:22 -0700 (PDT) From: Matt Brown To: skiboot@lists.ozlabs.org Date: Thu, 4 May 2017 10:23:52 +1000 Message-Id: <20170504002352.4683-1-matthew.brown.dev@gmail.com> X-Mailer: git-send-email 2.9.3 Subject: [Skiboot] [PATCH] gcov: Add gcov data struct to sysfs X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Extracting the skiboot gcov data is currently a tedious process which involves taking a mem dump of skiboot and searching for the gcov_info struct. This patch adds the gcov struct to sysfs under /opal/exports. Allowing the data to be copied directly into userspace and processed. Signed-off-by: Matt Brown --- core/gcov-profiling.c | 18 ++++++++++++++++++ core/opal.c | 9 +++++++++ 2 files changed, 27 insertions(+) diff --git a/core/gcov-profiling.c b/core/gcov-profiling.c index cf8b509..2d4b2b2 100644 --- a/core/gcov-profiling.c +++ b/core/gcov-profiling.c @@ -51,6 +51,8 @@ struct gcov_info *gcov_info_list; void __gcov_init(struct gcov_info* f); void skiboot_gcov_done(void); +void *skiboot_gcov_base(void); +int skiboot_gcov_size(void); void __gcov_flush(void) __attrconst; void __gcov_merge_add(gcov_type *counters, unsigned int n_counters) __attrconst; void __gcov_merge_single(gcov_type *counters, unsigned int n_counters) __attrconst; @@ -88,6 +90,22 @@ void skiboot_gcov_done(void) printf("GCOV: gcov_info_list at 0x%p\n", gcov_info_list); } +void *skiboot_gcov_base(void) +{ + return (void *)gcov_info_list; +} + +int skiboot_gcov_size(void) +{ + int n = 0; + struct gcov_info *i = gcov_info_list; + + while (i->next) { + n += sizeof(struct gcov_info); + i = i->next; + } + return n; +} void __gcov_merge_add(gcov_type *counters, unsigned int n_counters) { diff --git a/core/opal.c b/core/opal.c index a719d26..34263a5 100644 --- a/core/opal.c +++ b/core/opal.c @@ -51,6 +51,11 @@ static uint64_t opal_dynamic_events; extern uint32_t attn_trigger; extern uint32_t hir_trigger; +#ifdef SKIBOOT_GCOV +void *skiboot_gcov_base(void); +int skiboot_gcov_size(void); +#endif + void opal_table_init(void) { struct opal_table_entry *s = __opal_table_start; @@ -142,6 +147,10 @@ static void add_opal_firmware_exports_node(struct dt_node *node) dt_add_property_u64s(exports, "symbol_map", sym_start, sym_size); dt_add_property_u64s(exports, "hdat_map", SPIRA_HEAP_BASE, SPIRA_HEAP_SIZE); +#ifdef SKIBOOT_GCOV + dt_add_property_u64s(exports, "gcov", (uint64_t)skiboot_gcov_base(), + skiboot_gcov_size()); +#endif } static void add_opal_firmware_node(void)