| Message ID | 20170202041227.27638-1-benh@kernel.crashing.org |
|---|---|
| State | Accepted |
| Headers | show |
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes: > The IPLPARAMs lacking serial ports isn't an error. Since it > never happened on FSP machine and it's not used on BMC ones > there is no need to print a message at all > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- > hdata/spira.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Series merged to master as of a9f15f335ece51c7a279232b4a51f8b2554f581e
diff --git a/hdata/spira.c b/hdata/spira.c index 9ab7d35..4ebbc43 100644 --- a/hdata/spira.c +++ b/hdata/spira.c @@ -922,12 +922,10 @@ static void add_iplparams_serials(const void *iplp, struct dt_node *node) const struct iplparms_serial *ipser; struct dt_node *ser_node; int count, i; - + count = HDIF_get_iarray_size(iplp, IPLPARMS_IDATA_SERIAL); - if (count <= 0) { - prerror("IPLPARAMS: No serial ports\n"); + if (count <= 0) return; - } prlog(PR_INFO, "IPLPARAMS: %d serial ports in array\n", count); node = dt_new(node, "fsp-serial");
The IPLPARAMs lacking serial ports isn't an error. Since it never happened on FSP machine and it's not used on BMC ones there is no need to print a message at all Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> --- hdata/spira.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)