From patchwork Wed Mar 11 10:29:11 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mahesh J Salgaonkar X-Patchwork-Id: 448897 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 662ED1400D5 for ; Wed, 11 Mar 2015 21:30:17 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4F3D91A08CB for ; Wed, 11 Mar 2015 21:30:17 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from e23smtp01.au.ibm.com (e23smtp01.au.ibm.com [202.81.31.143]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id AADD01A075F for ; Wed, 11 Mar 2015 21:30:13 +1100 (AEDT) Received: from /spool/local by e23smtp01.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 11 Mar 2015 20:30:12 +1000 Received: from d23dlp02.au.ibm.com (202.81.31.213) by e23smtp01.au.ibm.com (202.81.31.207) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 11 Mar 2015 20:30:11 +1000 Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id DA81A2BB0047 for ; Wed, 11 Mar 2015 21:30:10 +1100 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t2BAU1153604496 for ; Wed, 11 Mar 2015 21:30:10 +1100 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t2BATaNw030338 for ; Wed, 11 Mar 2015 21:29:36 +1100 Received: from mars.in.ibm.com (mars.in.ibm.com [9.124.35.88]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t2BATYf2029329 for ; Wed, 11 Mar 2015 21:29:35 +1100 From: Mahesh J Salgaonkar To: skiboot list Date: Wed, 11 Mar 2015 15:59:11 +0530 Message-ID: <20150311102906.10209.13010.stgit@mars.in.ibm.com> In-Reply-To: <20150311102733.10209.5940.stgit@mars.in.ibm.com> References: <20150311102733.10209.5940.stgit@mars.in.ibm.com> User-Agent: StGit/0.17-dirty MIME-Version: 1.0 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15031110-1618-0000-0000-000001B8082F Subject: [Skiboot] [PATCH v2 1/9] Revert "opal: Handle more TFAC errors." X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" From: Mahesh Salgaonkar This reverts commit 699c433a8c736f44b13b7ba28cc0f9e0ac55840c. The rest of the patches in this series refactors the code that reset TB errors for better handling/recovery of individual TB errors. Hence Reverting old patch that claimed to handle more TFAC errors, but did not. Signed-off-by: Mahesh Salgaonkar --- hw/chiptod.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/hw/chiptod.c b/hw/chiptod.c index 49b84e7..edf805d 100644 --- a/hw/chiptod.c +++ b/hw/chiptod.c @@ -311,8 +311,6 @@ static bool chiptod_reset_tb_errors(void) tfmr |= SPR_TFMR_TB_MISSING_SYNC; tfmr |= SPR_TFMR_TB_MISSING_STEP; tfmr |= SPR_TFMR_TB_RESIDUE_ERR; - tfmr |= SPR_TFMR_FW_CONTROL_ERR; - tfmr |= SPR_TFMR_CHIP_TOD_PARITY_ERR; mtspr(SPR_TFMR, tfmr); /* We have to write "Clear TB Errors" again */ @@ -667,9 +665,6 @@ int chiptod_recover_tb_errors(void) * clear it. */ if ((tfmr & SPR_TFMR_TB_MISSING_STEP) || - (tfmr & SPR_TFMR_TB_RESIDUE_ERR) || - (tfmr & SPR_TFMR_FW_CONTROL_ERR) || - (tfmr & SPR_TFMR_CHIP_TOD_PARITY_ERR) || (tfmr & SPR_TFMR_TB_MISSING_SYNC)) { if (!chiptod_reset_tb_errors()) { rc = 0;