diff mbox series

SCOM restore for DARN and XIVE

Message ID 1509963486-21055-1-git-send-email-akshay.adiga@linux.vnet.ibm.com
State Changes Requested
Headers show
Series SCOM restore for DARN and XIVE | expand

Commit Message

Akshay Adiga Nov. 6, 2017, 10:18 a.m. UTC 
While waking up from stop11, we want NCU_DARN_BAR to have enable bit set.
Without this stop_api call, the value restored is without enable bit set.
We loose NCU_SPEC_BAR when the quad goes into stop11, stop_api will
restore while waking up from stop11.

---
 hw/nx.c   | 12 +++++++++++-
 hw/xive.c |  8 ++++++++
 2 files changed, 19 insertions(+), 1 deletion(-)

Comments

Stewart Smith Nov. 9, 2017, 6:36 a.m. UTC | #1 
Akshay Adiga <akshay.adiga@linux.vnet.ibm.com> writes:
> While waking up from stop11, we want NCU_DARN_BAR to have enable bit set.
> Without this stop_api call, the value restored is without enable bit set.
> We loose NCU_SPEC_BAR when the quad goes into stop11, stop_api will
> restore while waking up from stop11.

You are missing your Signed-off-by.
See https://github.com/open-power/skiboot/blob/master/CONTRIBUTING.md
diff mbox series

Patch

diff --git a/hw/nx.c b/hw/nx.c
index 64ac793..8431c3c 100644
--- a/hw/nx.c
+++ b/hw/nx.c
@@ -24,6 +24,7 @@ 
 #include <chip.h>
 #include <xscom-p9-regs.h>
 #include <phys-map.h>
+#include <p9_stop_api.H>
 
 extern void nx_p9_rng_init(void);
 
@@ -31,7 +32,7 @@  void nx_p9_rng_init(void)
 {
 	struct proc_chip *chip;
 	struct cpu_thread *c;
-	uint64_t bar, tmp;
+	uint64_t bar, tmp, rc;
 
 	if (proc_gen != proc_gen_p9)
 		return;
@@ -65,6 +66,15 @@  void nx_p9_rng_init(void)
 						P9X_EX_NCU_DARN_BAR);
 			xscom_write(chip->id, addr,
 				    bar | P9X_EX_NCU_DARN_BAR_EN);
+			rc = p9_stop_save_scom(( void *)chip->homer_base,
+				       	addr, bar | P9X_EX_NCU_DARN_BAR_EN,
+					P9_STOP_SCOM_REPLACE,
+					P9_STOP_SECTION_CORE_SCOM);
+			if (rc) {
+				prlog(PR_ERR,
+					" stopapi for DARN_BAR failed %lld",
+					rc);
+			}
 		}
 	}
 }
diff --git a/hw/xive.c b/hw/xive.c
index 4fd8a30..2235af3 100644
--- a/hw/xive.c
+++ b/hw/xive.c
@@ -24,6 +24,7 @@ 
 #include <bitmap.h>
 #include <buddy.h>
 #include <phys-map.h>
+#include <p9_stop_api.H>
 
 /* Use Block group mode to move chip_id into block .... */
 #define USE_BLOCK_GROUP_MODE
@@ -3111,6 +3112,7 @@  static void xive_configure_ex_special_bar(struct xive *x, struct cpu_thread *c)
 {
 	uint64_t xa, val;
 	int64_t rc;
+	struct proc_chip *chip = get_chip(c->chip_id);
 
 	xive_cpu_dbg(c, "Setting up special BAR\n");
 	xa = XSCOM_ADDR_P9_EX(pir_to_core_id(c->pir), P9X_EX_NCU_SPEC_BAR);
@@ -3123,6 +3125,12 @@  static void xive_configure_ex_special_bar(struct xive *x, struct cpu_thread *c)
 		xive_cpu_err(c, "Failed to setup NCU_SPEC_BAR\n");
 		/* XXXX  what do do now ? */
 	}
+	rc = p9_stop_save_scom(( void *)chip->homer_base, xa, val,
+				P9_STOP_SCOM_REPLACE, P9_STOP_SECTION_EQ_SCOM);
+	if (rc) {
+		xive_cpu_err(c, "STOP_API failed for NCU_SPEC_BAR rc=%lld\n",rc);
+
+	}
 }
 
 static void xive_provision_cpu(struct xive_cpu_state *xs, struct cpu_thread *c)