diff mbox

Remove multiple logging for un-handled fsp sub commands.

Message ID 1494566796-23098-1-git-send-email-ppaidipe@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

ppaidipe May 12, 2017, 5:26 a.m. UTC
If any new or unknown command need to be handled, just log
un-hnadled message from only fsp, not required from fsp-dpo.

cat /sys/firmware/opal/msglog | grep -i ,3
[  110.232114723,3] FSP: fsp_trigger_reset() entry
[  188.431793837,3] FSP #0: Link down, starting R&R
[  464.109239162,3] FSP #0: Got XUP with no pending message !
[  466.340598554,3] FSP-DPO: Unknown command 0xce0900
[  466.340600126,3] FSP: Unhandled message ce0900

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
---
 hw/fsp/fsp-dpo.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Vasant Hegde May 16, 2017, 5:05 a.m. UTC | #1
On 05/12/2017 10:56 AM, Pridhiviraj Paidipeddi wrote:
> If any new or unknown command need to be handled, just log
> un-hnadled message from only fsp, not required from fsp-dpo.
>
> cat /sys/firmware/opal/msglog | grep -i ,3
> [  110.232114723,3] FSP: fsp_trigger_reset() entry
> [  188.431793837,3] FSP #0: Link down, starting R&R
> [  464.109239162,3] FSP #0: Got XUP with no pending message !
> [  466.340598554,3] FSP-DPO: Unknown command 0xce0900
> [  466.340600126,3] FSP: Unhandled message ce0900
>
> Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>

Acked-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com>

-Vasant
Stewart Smith May 16, 2017, 5:36 a.m. UTC | #2
Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> writes:
> If any new or unknown command need to be handled, just log
> un-hnadled message from only fsp, not required from fsp-dpo.
>
> cat /sys/firmware/opal/msglog | grep -i ,3
> [  110.232114723,3] FSP: fsp_trigger_reset() entry
> [  188.431793837,3] FSP #0: Link down, starting R&R
> [  464.109239162,3] FSP #0: Got XUP with no pending message !
> [  466.340598554,3] FSP-DPO: Unknown command 0xce0900
> [  466.340600126,3] FSP: Unhandled message ce0900
>
> Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>

Merged to master as of 249731c071ad2d2a6703448295a07d82e99e3788
diff mbox

Patch

diff --git a/hw/fsp/fsp-dpo.c b/hw/fsp/fsp-dpo.c
index f6fadc5..66a240b 100644
--- a/hw/fsp/fsp-dpo.c
+++ b/hw/fsp/fsp-dpo.c
@@ -150,7 +150,6 @@  static bool fsp_dpo_message(u32 cmd_sub_mod, struct fsp_msg *msg)
 		return true;
 	}
 
-	prerror("Unknown command 0x%x\n", cmd_sub_mod);
 	return false;
 }