From patchwork Wed Feb 22 06:02:42 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ppaidipe X-Patchwork-Id: 730917 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3vSmym4Dhmz9s7R for ; Wed, 22 Feb 2017 17:04:00 +1100 (AEDT) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3vSmym3G8ZzDqH7 for ; Wed, 22 Feb 2017 17:04:00 +1100 (AEDT) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3vSmyg1P3tzDq5g for ; Wed, 22 Feb 2017 17:03:54 +1100 (AEDT) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.20/8.16.0.20) with SMTP id v1M5mpAJ014410 for ; Wed, 22 Feb 2017 01:03:53 -0500 Received: from e23smtp05.au.ibm.com (e23smtp05.au.ibm.com [202.81.31.147]) by mx0a-001b2d01.pphosted.com with ESMTP id 28rt1k7ts0-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 22 Feb 2017 01:03:52 -0500 Received: from localhost by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 22 Feb 2017 16:03:50 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp05.au.ibm.com (202.81.31.211) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 22 Feb 2017 16:03:49 +1000 Received: from d23relay07.au.ibm.com (d23relay07.au.ibm.com [9.190.26.37]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id 0D0843578058 for ; Wed, 22 Feb 2017 17:03:49 +1100 (EST) Received: from d23av06.au.ibm.com (d23av06.au.ibm.com [9.190.235.151]) by d23relay07.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v1M63egR42598524 for ; Wed, 22 Feb 2017 17:03:48 +1100 Received: from d23av06.au.ibm.com (localhost [127.0.0.1]) by d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id v1M63GqP017521 for ; Wed, 22 Feb 2017 17:03:16 +1100 Received: from localhost.in.ibm.com ([9.124.158.62]) by d23av06.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id v1M63Esb016854; Wed, 22 Feb 2017 17:03:14 +1100 From: ppaidipe@linux.vnet.ibm.com To: skiboot@lists.ozlabs.org Date: Wed, 22 Feb 2017 11:32:42 +0530 X-Mailer: git-send-email 2.7.4 X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17022206-0016-0000-0000-0000021C81AC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17022206-0017-0000-0000-0000067615C6 Message-Id: <1487743362-1160-1-git-send-email-ppaidipe@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-02-22_03:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702220059 Subject: [Skiboot] [PATCH v2] Fix hvc console issue by using OPAL event. X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alistair@popple.id.au, sam@mendozajonas.com MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" From: Pridhiviraj Paidipeddi This reverts part of commit 583c8203dcb26b42cea81e4734ea926dae05dbb9. Below is the WARNING in pre 4.2 linux kernels which is raised in firenze systems due to interrupts mapping failure. [ 0.947741] irq: irq-62==>hwirq-0x3e mapping failed: -22 [ 0.947793] ------------[ cut here ]------------ [ 0.947838] WARNING: at kernel/irq/irqdomain.c:485 So this commit 583c8203dcb26b42cea81e4734ea926dae05dbb9 is causing the above kernel WARNING(found by git-bisect). As per suggestion by Alistair, Use OPAL event instead of interrupts to avoid the warning. Tested on RHEL and Ubuntu OS's, not seen any kernel warning's. [ 1.745145] hvc0: raw protocol on /ibm,opal/consoles/serial@0 (boot console) [ 1.745223] hvc0: No interrupts property, using OPAL event [ 1.745556] hvc1: hvsi protocol on /ibm,opal/consoles/serial@1 [ 1.745622] hvc1: No interrupts property, using OPAL event Signed-off-by: Pridhiviraj Paidipeddi --- Changes since v1: Use OPAL event instead of interrupts to avoid the kernel warning. hw/fsp/fsp-console.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c index 6683679..2785a82 100644 --- a/hw/fsp/fsp-console.c +++ b/hw/fsp/fsp-console.c @@ -929,10 +929,8 @@ void fsp_console_reset(void) void fsp_console_add_nodes(void) { - struct dt_node *opal_event; unsigned int i; - opal_event = dt_find_by_name(opal_node, "event"); for (i = 0; i < MAX_SERIAL; i++) { struct fsp_serial *fs = &fsp_serials[i]; @@ -951,10 +949,6 @@ void fsp_console_add_nodes(void) fs->irq = opal_dynamic_event_alloc(); dt_add_property_cells(fs_node, "interrupts", ilog2(fs->irq)); - - if (opal_event) - dt_add_property_cells(fs_node, "interrupt-parent", - opal_event->phandle); } }