| Message ID | 1479719475-5905-2-git-send-email-ppaidipe@linux.vnet.ibm.com |
|---|---|
| State | Rejected |
| Headers | show |
Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> writes: > To make use of fwts annotations change prerror to prlog call > > Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> Instead, I wrote https://patchwork.ozlabs.org/patch/708376/ to parse the prerror() calls - which has the same effect and means we can continue to just use prerror() rather than having to convert everything (even though we're a fair way through that).
On 2016-12-23 09:26, Stewart Smith wrote: > Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> writes: >> To make use of fwts annotations change prerror to prlog call >> >> Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> > > Instead, I wrote https://patchwork.ozlabs.org/patch/708376/ to parse > the > prerror() calls - which has the same effect and means we can continue > to > just use prerror() rather than having to convert everything (even > though > we're a fair way through that). Thanks Stewart.
diff --git a/hw/xscom.c b/hw/xscom.c index e51f182..7815828 100644 --- a/hw/xscom.c +++ b/hw/xscom.c @@ -440,7 +440,7 @@ int xscom_read(uint32_t partid, uint64_t pcb_addr, uint64_t *val) * someone to try an xscom_read on something that isn't a * processor, Centaur or EX chiplet. */ - prerror("%s: invalid XSCOM partid 0x%x\n", __func__, partid); + prlog(PR_ERR, "%s: invalid XSCOM partid 0x%x\n", __func__, partid); return OPAL_PARAMETER; } @@ -483,7 +483,7 @@ int xscom_write(uint32_t partid, uint64_t pcb_addr, uint64_t val) * someone to try an xscom_write on something that isn't a * processor, Centaur or EX chiplet. */ - prerror("%s: invalid XSCOM partid 0x%x\n", __func__, partid); + prlog(PR_ERR, "%s: invalid XSCOM partid 0x%x\n", __func__, partid); return OPAL_PARAMETER; }
To make use of fwts annotations change prerror to prlog call Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com> --- hw/xscom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)