From patchwork Fri Nov 18 05:01:40 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver O'Halloran X-Patchwork-Id: 696409 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3tKm8P1sxHz9syB for ; Fri, 18 Nov 2016 16:02:45 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="a4Iffrio"; dkim-atps=neutral Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3tKm8P0dmHzDvx5 for ; Fri, 18 Nov 2016 16:02:45 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="a4Iffrio"; dkim-atps=neutral X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mail-pg0-x243.google.com (mail-pg0-x243.google.com [IPv6:2607:f8b0:400e:c05::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3tKm7p4Sn1zDvvt for ; Fri, 18 Nov 2016 16:02:14 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="a4Iffrio"; dkim-atps=neutral Received: by mail-pg0-x243.google.com with SMTP id 3so19519645pgd.0 for ; Thu, 17 Nov 2016 21:02:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=S5u5NNyT2afe82xS7qpvdHSGB46coIKCvD46LJHBMoI=; b=a4IffriohJr0XBnzzt8QAa3Qn470xD41CQJ6htz6wsm5MFArUxZ7tLusbLYut8ldCW aNChyhyhS6lKTm61hZRyI1z/4MioVsLGTrmXQQd/auR6zwGjv9K/H0TXfR3So7H5nkH2 M3BUBN8v+KRd7LgaWj6/cGKWCj1dcDs7mkdUVOHAo/ZN6FecZF2QMklKmpnTLINJR6c2 XTgBxHomq346hJ/Hy4NC7k6Hb9w/8hWFVut5EY/uryk7Bz3Om1eB+QMzUKeQ2E1th2bC SHCZUwMF1Q9/kvD8a1DZaDMZJtXNG0R/T4qaWUZh53zyiALKixbECSI2qQgtXr++39p2 XW7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=S5u5NNyT2afe82xS7qpvdHSGB46coIKCvD46LJHBMoI=; b=AddYcJP8J7/4LSMCLL8FoR1adpCzwiXMxg6IFxOY+TipkaKOczfw+PnRGtN+F8Wn8S /wqi/UysuZEcZdsqs+OvXpU6nK5RzkF6kgtCUwEaiMrqDiFn8Rtvq+Wp51IXH0KfN0pV WWzZqE4t4ux9xbdGcs8iEHFk9BboTQ4Hh903/BMoccNgYMKmgnY96+B/SND6Bv2GFdHG FLJwnUWQ+Gx3geiIAQZbQTZZ2DdoneO4cWxU99ljjM89oCIR9OrgvgiFaBDh+kQkoMO9 yeGWisUvbpkCnsCWRzFpod6l/Brm/4jih0eLLPvkq0HrpUpeSjdJalfU/8k+sVkWvK7j felA== X-Gm-Message-State: ABUngvd5o65i7Jl7Vr+LSTwnSHTiuHeWv0KTjYGsRabt8YmC3mZvw5ztStk0Hk0xaUWCFQ== X-Received: by 10.98.97.7 with SMTP id v7mr6470787pfb.39.1479445332653; Thu, 17 Nov 2016 21:02:12 -0800 (PST) Received: from canetoad.ozlabs.ibm.com ([122.99.82.10]) by smtp.gmail.com with ESMTPSA id x90sm12613462pfk.73.2016.11.17.21.02.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Nov 2016 21:02:12 -0800 (PST) From: Oliver O'Halloran To: skiboot@lists.ozlabs.org Date: Fri, 18 Nov 2016 16:01:40 +1100 Message-Id: <1479445312-12382-3-git-send-email-oohall@gmail.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1479445312-12382-1-git-send-email-oohall@gmail.com> References: <1479445312-12382-1-git-send-email-oohall@gmail.com> Subject: [Skiboot] [PATCH 02/14] console: unexport con_lock X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" The skiboot console lock protects the skiboot log buffer. All writes to the log buffer need to be done via console_write() so there is no need to export the lock outside console.c Signed-off-by: Oliver O'Halloran --- core/console.c | 2 +- include/console.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/core/console.c b/core/console.c index 0e96bf4593eb..20de285f5104 100644 --- a/core/console.c +++ b/core/console.c @@ -33,7 +33,7 @@ static size_t con_out; static bool con_wrapped; static struct con_ops *con_driver; -struct lock con_lock = LOCK_UNLOCKED; +static struct lock con_lock = LOCK_UNLOCKED; /* This is mapped via TCEs so we keep it alone in a page */ struct memcons memcons __section(".data.memcons") = { diff --git a/include/console.h b/include/console.h index f88547c7791e..4c77433421f6 100644 --- a/include/console.h +++ b/include/console.h @@ -54,8 +54,6 @@ struct con_ops { int64_t (*flush)(void); }; -extern struct lock con_lock; - extern bool dummy_console_enabled(void); extern void force_dummy_console(void); extern bool flush_console(void);