diff mbox

occ: use tb_to_msec rather than hard coding it

Message ID 1473839038-4151-1-git-send-email-stewart@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

Stewart Smith Sept. 14, 2016, 7:43 a.m. UTC 
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
---
 hw/occ.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vaidyanathan Srinivasan Sept. 14, 2016, 7:56 a.m. UTC | #1 
* Stewart Smith <stewart@linux.vnet.ibm.com> [2016-09-14 17:43:58]:

> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>

Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>

> ---
>  hw/occ.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/occ.c b/hw/occ.c
> index b606a675390f..c8457320dad4 100644
> --- a/hw/occ.c
> +++ b/hw/occ.c
> @@ -154,8 +154,8 @@ static bool wait_for_all_occ_init(void)
>  		      *(uint64_t *)occ_data_area);
>  	}
>  	end_time = mftb();
> -	prlog(PR_NOTICE, "OCC: All Chip Rdy after %lld ms\n",
> -	      (end_time - start_time) / 512 / 1000);
> +	prlog(PR_NOTICE, "OCC: All Chip Rdy after %lu ms\n",
> +	      tb_to_msecs(end_time - start_time));
>  	return true;
>  }

Thanks Stewart for the cleanup.

--Vaidy
Stewart Smith Sept. 14, 2016, 8:19 a.m. UTC | #2 
Stewart Smith <stewart@linux.vnet.ibm.com> writes:
> Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com>
> ---
>  hw/occ.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

and merged to master as of 5fae412d26fc53aa6c5f4c1a3ff4d089e1f2108b
diff mbox

Patch

diff --git a/hw/occ.c b/hw/occ.c
index b606a675390f..c8457320dad4 100644
--- a/hw/occ.c
+++ b/hw/occ.c
@@ -154,8 +154,8 @@  static bool wait_for_all_occ_init(void)
 		      *(uint64_t *)occ_data_area);
 	}
 	end_time = mftb();
-	prlog(PR_NOTICE, "OCC: All Chip Rdy after %lld ms\n",
-	      (end_time - start_time) / 512 / 1000);
+	prlog(PR_NOTICE, "OCC: All Chip Rdy after %lu ms\n",
+	      tb_to_msecs(end_time - start_time));
 	return true;
 }