| Message ID | 1472722713-20843-1-git-send-email-stewart@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On Thursday 01 September 2016 03:08 PM, Stewart Smith wrote: > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> Reviewed-by: Mukesh Ojha <mukesh02@linux.vnet.ibm.com> -Mukesh > --- > libc/string/strlen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libc/string/strlen.c b/libc/string/strlen.c > index 37a1b7812e3c..95b99d25455f 100644 > --- a/libc/string/strlen.c > +++ b/libc/string/strlen.c > @@ -15,7 +15,7 @@ > size_t > strlen(const char *s) > { > - int len = 0; > + size_t len = 0; > > while (*s != 0) { > len += 1;
On Thursday 01 September 2016 03:08 PM, Stewart Smith wrote: > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> > --- > libc/string/strlen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libc/string/strlen.c b/libc/string/strlen.c > index 37a1b7812e3c..95b99d25455f 100644 > --- a/libc/string/strlen.c > +++ b/libc/string/strlen.c > @@ -15,7 +15,7 @@ > size_t > strlen(const char *s) > { > - int len = 0; > + size_t len = 0; There are many places in skiboot sources where the return value of strlen is taken in 'int'. -Mukesh > > while (*s != 0) { > len += 1;
Stewart Smith <stewart@linux.vnet.ibm.com> writes: > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> > --- > libc/string/strlen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > merged to master as of 19ed47363f85634bda960ebe4511829d0d5ecced
diff --git a/libc/string/strlen.c b/libc/string/strlen.c index 37a1b7812e3c..95b99d25455f 100644 --- a/libc/string/strlen.c +++ b/libc/string/strlen.c @@ -15,7 +15,7 @@ size_t strlen(const char *s) { - int len = 0; + size_t len = 0; while (*s != 0) { len += 1;
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> --- libc/string/strlen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)