diff mbox

log_level: Reduce the in memory console log_level to lower priority

Message ID 1470116048-10218-1-git-send-email-ppaidipe@linux.vnet.ibm.com
State Accepted
Headers show

Commit Message

ppaidipe Aug. 2, 2016, 5:34 a.m. UTC
From: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>

Below are the in-memory console log messages observed with error level(PR_ERROR)

[54460318,3] HBRT: Mem region 'ibm,homer-image' not found !
[54465404,3] HBRT: Mem region 'ibm,homer-image' not found !
[54470372,3] HBRT: Mem region 'ibm,homer-image' not found !
[54475369,3] HBRT: Mem region 'ibm,homer-image' not found !
[11540917382,3] NVRAM: Layout appears sane
[11694529822,3] OPAL: Trying a CPU re-init with flags: 0x2
[61291003267,3] OPAL: Trying a CPU re-init with flags: 0x1
[61394005956,3] OPAL: Trying a CPU re-init with flags: 0x2

Lowering the log level of mem region not found messages to PR_WARNING and remaining messages to PR_INFO level

[54811683,4] HBRT: Mem region 'ibm,homer-image' not found !
[10923382751,6] NVRAM: Layout appears sane
[55533988976,6] OPAL: Trying a CPU re-init with flags: 0x1

Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
---
 core/cpu.c          | 2 +-
 core/hostservices.c | 2 +-
 core/nvram-format.c | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Stewart Smith Aug. 2, 2016, 8:18 a.m. UTC | #1
ppaidipe@linux.vnet.ibm.com writes:
> From: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
>
> Below are the in-memory console log messages observed with error level(PR_ERROR)
>
> [54460318,3] HBRT: Mem region 'ibm,homer-image' not found !
> [54465404,3] HBRT: Mem region 'ibm,homer-image' not found !
> [54470372,3] HBRT: Mem region 'ibm,homer-image' not found !
> [54475369,3] HBRT: Mem region 'ibm,homer-image' not found !
> [11540917382,3] NVRAM: Layout appears sane
> [11694529822,3] OPAL: Trying a CPU re-init with flags: 0x2
> [61291003267,3] OPAL: Trying a CPU re-init with flags: 0x1
> [61394005956,3] OPAL: Trying a CPU re-init with flags: 0x2
>
> Lowering the log level of mem region not found messages to PR_WARNING and remaining messages to PR_INFO level
>
> [54811683,4] HBRT: Mem region 'ibm,homer-image' not found !
> [10923382751,6] NVRAM: Layout appears sane
> [55533988976,6] OPAL: Trying a CPU re-init with flags: 0x1
>
> Signed-off-by: Pridhiviraj Paidipeddi <ppaidipe@linux.vnet.ibm.com>
> ---
>  core/cpu.c          | 2 +-
>  core/hostservices.c | 2 +-
>  core/nvram-format.c | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

THanks!

Merged to master as of 341daa8104af3231b908e6fcffeedb5e47b33990

I've also cherry picked these back to 5.1.x and 5.3.x stable trees:
[skiboot-5.3.x 7aabae2]
[skiboot-5.1.x 3560f40]
diff mbox

Patch

diff --git a/core/cpu.c b/core/cpu.c
index f33ac48..a94c17a 100644
--- a/core/cpu.c
+++ b/core/cpu.c
@@ -824,7 +824,7 @@  static int64_t opal_reinit_cpus(uint64_t flags)
 	int64_t rc = OPAL_SUCCESS;
 	int i;
 
-	prerror("OPAL: Trying a CPU re-init with flags: 0x%llx\n", flags);
+	prlog(PR_INFO, "OPAL: Trying a CPU re-init with flags: 0x%llx\n", flags);
 
  again:
 	lock(&reinit_lock);
diff --git a/core/hostservices.c b/core/hostservices.c
index 6aea670..d1f6fda 100644
--- a/core/hostservices.c
+++ b/core/hostservices.c
@@ -531,7 +531,7 @@  static uint64_t hservice_get_reserved_mem(const char *name)
 	unlock(&mem_region_lock);
 
 	if (!ret)
-		prerror("HBRT: Mem region '%s' not found !\n", name);
+		prlog(PR_WARNING, "HBRT: Mem region '%s' not found !\n", name);
 
 	return ret;
 }
diff --git a/core/nvram-format.c b/core/nvram-format.c
index 1c164d4..5a16fd3 100644
--- a/core/nvram-format.c
+++ b/core/nvram-format.c
@@ -157,7 +157,7 @@  int nvram_check(void *nvram_image, const uint32_t nvram_size)
 		goto failed;
 	}
 
-	prerror("NVRAM: Layout appears sane\n");
+	prlog(PR_INFO, "NVRAM: Layout appears sane\n");
 	return 0;
  failed:
 	return -1;