diff mbox

[01/34] centaur: Initialize i2c master list

Message ID 1469316448-6176-1-git-send-email-benh@kernel.crashing.org
State Accepted
Headers show

Commit Message

Benjamin Herrenschmidt July 23, 2016, 11:26 p.m. UTC 
It was left uninitialized which could cause issues later on

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
 hw/centaur.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Stewart Smith July 27, 2016, 8:08 a.m. UTC | #1 
Benjamin Herrenschmidt <benh@kernel.crashing.org> writes:
> It was left uninitialized which could cause issues later on
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

Good obvious fix, merged to master as of f4704f5592b00dd465711cc374f478bdf8d31d86
Stewart Smith Aug. 23, 2016, 5:34 a.m. UTC | #2 
Series merged! Except for the couple I pointed out (14,32 and 33 IIRC),
everything looks really rather solid.
diff mbox

Patch

diff --git a/hw/centaur.c b/hw/centaur.c
index 5e594c1..1f2b9c4 100644
--- a/hw/centaur.c
+++ b/hw/centaur.c
@@ -426,6 +426,7 @@  static bool centaur_add(uint32_t part_id, uint32_t mchip, uint32_t meng,
 	centaur->fsi_master_port = mport;
 	centaur->fsi_master_engine = meng ? MFSI_cMFSI1 : MFSI_cMFSI0;
 	init_lock(&centaur->lock);
+	list_head_init(&centaur->i2cms);
 
 	if (!centaur_check_id(centaur))
 		return false;