| Message ID | 1467005532-17667-9-git-send-email-stewart@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
* Stewart Smith <stewart@linux.vnet.ibm.com> [2016-06-27 15:32:06]: > Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> > --- > hw/slw.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/hw/slw.c b/hw/slw.c > index f174ae4f3462..7359b73e93f7 100644 > --- a/hw/slw.c > +++ b/hw/slw.c > @@ -591,6 +591,12 @@ void add_cpu_idle_state_properties(void) > /* Create /ibm,opal/power-mgt */ > power_mgt = dt_new(opal_node, "power-mgt"); > if (!power_mgt) { > + /** > + * @fwts-label CreateDTPowerMgtNodeFail > + * @fwts-advice OPAL failed to add the power-mgt device tree > + * node. This coudl mean that firmware ran out of memory, ^could > + * or there's a bug somewhere. > + */ > prlog(PR_ERR, "creating dt node /ibm,opal/power-mgt failed\n"); > return; > } > @@ -1184,6 +1190,13 @@ static void slw_dump_timer_ffdc(void) > 0x50038, 0x50039, 0x5003a, 0x5003b > }; > > + /** > + * @fwts-label SLWRegisterDump > + * @fwts-advice An error condition occured where the SLeep/Winkle > + * engine had to dump out the register state for assisitng in > + * debugging. This means that power saving states are likely > + * not functioning correctly. > + */ An error condition occurred in sleep/winkle engines timer state machine. Dumping debug information to root-cause. OPAL/skiboot may be stuck on some operation that require SLW timer state machine. > prlog(PR_ERR, "SLW: Register state:\n"); > > for (i = 0; i < ARRAY_SIZE(dump_regs); i++) { > -- > 2.1.4 > > _______________________________________________ > Skiboot mailing list > Skiboot@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/skiboot
diff --git a/hw/slw.c b/hw/slw.c index f174ae4f3462..7359b73e93f7 100644 --- a/hw/slw.c +++ b/hw/slw.c @@ -591,6 +591,12 @@ void add_cpu_idle_state_properties(void) /* Create /ibm,opal/power-mgt */ power_mgt = dt_new(opal_node, "power-mgt"); if (!power_mgt) { + /** + * @fwts-label CreateDTPowerMgtNodeFail + * @fwts-advice OPAL failed to add the power-mgt device tree + * node. This coudl mean that firmware ran out of memory, + * or there's a bug somewhere. + */ prlog(PR_ERR, "creating dt node /ibm,opal/power-mgt failed\n"); return; } @@ -1184,6 +1190,13 @@ static void slw_dump_timer_ffdc(void) 0x50038, 0x50039, 0x5003a, 0x5003b }; + /** + * @fwts-label SLWRegisterDump + * @fwts-advice An error condition occured where the SLeep/Winkle + * engine had to dump out the register state for assisitng in + * debugging. This means that power saving states are likely + * not functioning correctly. + */ prlog(PR_ERR, "SLW: Register state:\n"); for (i = 0; i < ARRAY_SIZE(dump_regs); i++) {
Signed-off-by: Stewart Smith <stewart@linux.vnet.ibm.com> --- hw/slw.c | 13 +++++++++++++ 1 file changed, 13 insertions(+)