From patchwork Mon Jun 20 08:28:18 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stewart Smith X-Patchwork-Id: 637870 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 3rY3sg3Gsgz9sBm for ; Mon, 20 Jun 2016 18:28:39 +1000 (AEST) Received: from ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 3rY3sg2TXjzDqDN for ; Mon, 20 Jun 2016 18:28:39 +1000 (AEST) X-Original-To: skiboot@lists.ozlabs.org Delivered-To: skiboot@lists.ozlabs.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rY3sY0YqgzDq5d for ; Mon, 20 Jun 2016 18:28:32 +1000 (AEST) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u5K8NrSE022944 for ; Mon, 20 Jun 2016 04:28:30 -0400 Received: from e31.co.us.ibm.com (e31.co.us.ibm.com [32.97.110.149]) by mx0a-001b2d01.pphosted.com with ESMTP id 23my6emda1-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Mon, 20 Jun 2016 04:28:30 -0400 Received: from localhost by e31.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 20 Jun 2016 02:28:30 -0600 Received: from d03dlp02.boulder.ibm.com (9.17.202.178) by e31.co.us.ibm.com (192.168.1.131) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 20 Jun 2016 02:28:27 -0600 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: stewart@linux.vnet.ibm.com X-IBM-RcptTo: skiboot@lists.ozlabs.org Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 38D7A3E40044 for ; Mon, 20 Jun 2016 02:28:27 -0600 (MDT) Received: from b03ledav002.gho.boulder.ibm.com (b03ledav002.gho.boulder.ibm.com [9.17.130.233]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u5K8SRZP42074190; Mon, 20 Jun 2016 01:28:27 -0700 Received: from b03ledav002.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 17D42136046; Mon, 20 Jun 2016 02:28:27 -0600 (MDT) Received: from birb.localdomain (unknown [9.83.5.130]) by b03ledav002.gho.boulder.ibm.com (Postfix) with SMTP id 634B413603C; Mon, 20 Jun 2016 02:28:26 -0600 (MDT) Received: from ka1.ozlabs.ibm.com (localhost.localdomain [127.0.0.1]) by birb.localdomain (Postfix) with ESMTP id 4D226229EAB1; Mon, 20 Jun 2016 18:28:22 +1000 (AEST) From: Stewart Smith To: skiboot@lists.ozlabs.org Date: Mon, 20 Jun 2016 18:28:18 +1000 X-Mailer: git-send-email 2.1.4 In-Reply-To: <1466411300-10047-1-git-send-email-stewart@linux.vnet.ibm.com> References: <1466411300-10047-1-git-send-email-stewart@linux.vnet.ibm.com> X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16062008-8235-0000-0000-000008A0A86B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16062008-8236-0000-0000-00003262B0F2 Message-Id: <1466411300-10047-2-git-send-email-stewart@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-06-20_06:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=1 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1606200101 Subject: [Skiboot] [PATCH 2/4] fwts: add annotations for core flash/nvram functionality X-BeenThere: skiboot@lists.ozlabs.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Mailing list for skiboot development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: skiboot-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Skiboot" Signed-off-by: Stewart Smith --- core/flash.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/core/flash.c b/core/flash.c index 734e0fab1d36..6c0d2ffea9ab 100644 --- a/core/flash.c +++ b/core/flash.c @@ -277,12 +277,24 @@ int flash_register(struct blocklevel_device *bl, bool is_system_flash) if (!flash) { unlock(&flash_lock); + /** + * @fwts-label NoFlashSlots + * @fwts-advice System has more flash chips than skiboot + * was configured to know about. Your system will not be + * able to access some of the flash it has. + */ prlog(PR_ERR, "FLASH: No flash slots available\n"); return OPAL_RESOURCE; } rc = ffs_init(0, flash->size, bl, &ffs, 0); if (rc) { + /** + * @fwts-label NoFFS + * @fwts-advice System flash isn't formatted as expected. + * This could mean several OPAL utilities do not function + * as expected. e.g. gard, pflash. + */ prlog(PR_WARNING, "FLASH: No ffs info; " "using raw device only\n"); ffs = NULL;