| Message ID | 1466069482-7296-1-git-send-email-hegdevasant@linux.vnet.ibm.com |
|---|---|
| State | Accepted |
| Headers | show |
On Thu, 2016-06-16 at 15:01 +0530, Vasant Hegde wrote: > Commit 3ff35034 (Abstract HILE and attn enable bit definitions for HID0) > enabled HILE bit instead of ATTN bit in enable/disable_attn fuction. > Hence OPAL assert is failing. Oops, my bad. Thanks for fixing. Mikey > > Fixes: 3ff35034 (Abstract HILE and attn enable bit definitions for HID0) > CC: Michael Neuling <mikey@neuling.org> > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > core/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/core/cpu.c b/core/cpu.c > index b5a3614..ffc264f 100644 > --- a/core/cpu.c > +++ b/core/cpu.c > @@ -411,7 +411,7 @@ static void enable_attn(void) > unsigned long hid0; > > hid0 = mfspr(SPR_HID0); > - hid0 |= hid0_hile; > + hid0 |= hid0_attn; > set_hid0(hid0); > } > > @@ -420,7 +420,7 @@ static void disable_attn(void) > unsigned long hid0; > > hid0 = mfspr(SPR_HID0); > - hid0 &= ~hid0_hile; > + hid0 &= ~hid0_attn; > set_hid0(hid0); > } >
Vasant Hegde <hegdevasant@linux.vnet.ibm.com> writes: > Commit 3ff35034 (Abstract HILE and attn enable bit definitions for HID0) > enabled HILE bit instead of ATTN bit in enable/disable_attn fuction. > Hence OPAL assert is failing. > > Fixes: 3ff35034 (Abstract HILE and attn enable bit definitions for HID0) > CC: Michael Neuling <mikey@neuling.org> > Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> > --- > core/cpu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Thanks for spotting that. Bit embarassing I missed it too. Merged to master as of c600283
diff --git a/core/cpu.c b/core/cpu.c index b5a3614..ffc264f 100644 --- a/core/cpu.c +++ b/core/cpu.c @@ -411,7 +411,7 @@ static void enable_attn(void) unsigned long hid0; hid0 = mfspr(SPR_HID0); - hid0 |= hid0_hile; + hid0 |= hid0_attn; set_hid0(hid0); } @@ -420,7 +420,7 @@ static void disable_attn(void) unsigned long hid0; hid0 = mfspr(SPR_HID0); - hid0 &= ~hid0_hile; + hid0 &= ~hid0_attn; set_hid0(hid0); }
Commit 3ff35034 (Abstract HILE and attn enable bit definitions for HID0) enabled HILE bit instead of ATTN bit in enable/disable_attn fuction. Hence OPAL assert is failing. Fixes: 3ff35034 (Abstract HILE and attn enable bit definitions for HID0) CC: Michael Neuling <mikey@neuling.org> Signed-off-by: Vasant Hegde <hegdevasant@linux.vnet.ibm.com> --- core/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)